Merged
Conversation
Collaborator
|
r? @davidtwco (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Collaborator
|
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri |
klensy
commented
Nov 13, 2023
| } | ||
|
|
||
| impl UnsafetyViolationDetails { | ||
| pub fn description_and_note(&self) -> (&'static str, &'static str) { |
Contributor
Author
There was a problem hiding this comment.
Big nice function but no usage, sus.
This comment has been minimized.
This comment has been minimized.
RalfJung
reviewed
Nov 13, 2023
RalfJung
reviewed
Nov 13, 2023
This comment has been minimized.
This comment has been minimized.
davidtwco
approved these changes
Nov 19, 2023
Member
davidtwco
left a comment
davidtwco
left a comment
There was a problem hiding this comment.
LGTM, r=me after the two comments are addressed
| return false; | ||
| } | ||
| let pin_did = self.tcx.lang_items().pin_type(); | ||
| // FIXME: replace mk_box with? |
Contributor
Author
There was a problem hiding this comment.
There still no unwrap here, should it be This guards the new_box below. or remove comment completely?
Contributor
Author
There was a problem hiding this comment.
added review commit.
Collaborator
|
☔ The latest upstream changes (presumably #118143) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
Author
|
Rebased, should i squash? |
Collaborator
|
☔ The latest upstream changes (presumably #118178) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 25, 2023
remove unused pub fns This removes some unused `pub fn`; also fixes few obsoleted fn names or added fixmes with reminders to update them.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 25, 2023
…llaumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#116446 (Yeet `mir::Const::from_anon_const`) - rust-lang#117871 (remove unused pub fns) - rust-lang#118017 (rustc_lint: address latent TODO) - rust-lang#118199 (Remove `HirId` from `QPath::LangItem`) - rust-lang#118272 (resolve: Avoid clones of `MacroData`) - rust-lang#118291 (rustdoc-search: clean up some DOM code) Failed merges: - rust-lang#118201 (Miscellaneous `ObligationCauseCode` cleanups) - rust-lang#118256 (rustc: `hir().local_def_id_to_hir_id()` -> `tcx.local_def_id_to_hir_id()` cleanup) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 25, 2023
Rollup merge of rust-lang#117871 - klensy:unused-pub, r=cjgillot remove unused pub fns This removes some unused `pub fn`; also fixes few obsoleted fn names or added fixmes with reminders to update them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes some unused
pub fn; also fixes few obsoleted fn names or added fixmes with reminders to update them.