Skip to content

test: Add test for async-move in 2015 Rust proc macro#117973

Merged
bors merged 1 commit into
rust-lang:masterfrom
CohenArthur:fix-89699
Nov 21, 2023
Merged

test: Add test for async-move in 2015 Rust proc macro#117973
bors merged 1 commit into
rust-lang:masterfrom
CohenArthur:fix-89699

Conversation

@CohenArthur

@CohenArthur CohenArthur commented Nov 16, 2023

Copy link
Copy Markdown
Contributor

Fixes #89699

Ran cargo bisect-rustc to find when this was fixed exactly, which is in 474709a

@rustbot

rustbot commented Nov 16, 2023

Copy link
Copy Markdown
Collaborator

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 16, 2023
lqd
lqd reviewed Nov 16, 2023
View reviewed changes
Comment thread tests/ui/proc-macro/auxiliary/async-move.rs Outdated
@lqd

lqd commented Nov 16, 2023

Copy link
Copy Markdown
Member

Actually I'll take this from you @wesleywiser, the bot is also assigning you a million PRs to review.

r? lqd

@rustbot rustbot assigned lqd and unassigned wesleywiser Nov 16, 2023
lqd
lqd reviewed Nov 16, 2023
View reviewed changes

@lqd lqd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are a couple things of note:

  • Naming: according to rust-lang/compiler-team#658 the test name should be more representative. Something like "edition gated syntax issue 89699" will work fine, and let's make sure both the test and proc-macro share most of that same name.
  • Let's add a couple comments to both the test and the proc macro aux.
  • And remove the println of course

Comment thread tests/ui/proc-macro/auxiliary/async-move.rs
Comment thread tests/ui/proc-macro/issue-89699.rs Outdated
@lqd

lqd commented Nov 16, 2023

Copy link
Copy Markdown
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2023
@CohenArthur

CohenArthur commented Nov 20, 2023

Copy link
Copy Markdown
Contributor Author

Fixed review comments in c639090

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@CohenArthur

CohenArthur commented Nov 20, 2023

Copy link
Copy Markdown
Contributor Author

rebased and tidied up

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@lqd

lqd commented Nov 20, 2023

Copy link
Copy Markdown
Member

@CohenArthur please rebless and squash the 2 commits and we're good to go.

@CohenArthur
test: Add test for async-move in 2015 Rust proc macro
fd70a4c 
Add a test to ensure issue rust-lang#89699 does not show up again. This test
emits an `async move` closure in a proc macro, which is used in a
test program compiled with edition 2015. We make sure the error message
is nice and shows up properly.
@CohenArthur

CohenArthur commented Nov 20, 2023

Copy link
Copy Markdown
Contributor Author

thanks @lqd ❤️

@lqd

lqd commented Nov 20, 2023

Copy link
Copy Markdown
Member

on va y arriver :3

@lqd

lqd commented Nov 20, 2023

Copy link
Copy Markdown
Member

Thanks!

@bors r+ rollup

@bors

bors commented Nov 20, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit fd70a4c has been approved by lqd

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 20, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 20, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 20, 2023
@bors
Auto merge of rust-lang#118107 - matthiaskrgr:rollup-k5bfkfr, r=matth…
b8e8b47 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#117327 (Add documentation for some queries)
 - rust-lang#117835 (Note about object lifetime defaults in does not live long enough error)
 - rust-lang#117851 (Uplift `InferConst` to `rustc_type_ir`)
 - rust-lang#117973 (test: Add test for async-move in 2015 Rust proc macro)
 - rust-lang#117992 (Don't require intercrate mode for negative coherence)
 - rust-lang#118010 (Typeck break expr even if break is illegal)
 - rust-lang#118026 (Don't consider regions in `deref_into_dyn_supertrait` lint)
 - rust-lang#118089 (intercrate_ambiguity_causes: handle self ty infer + reservation impls)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 20, 2023
@bors
Auto merge of rust-lang#118107 - matthiaskrgr:rollup-k5bfkfr, r=matth…
549c0b9 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#117327 (Add documentation for some queries)
 - rust-lang#117835 (Note about object lifetime defaults in does not live long enough error)
 - rust-lang#117851 (Uplift `InferConst` to `rustc_type_ir`)
 - rust-lang#117973 (test: Add test for async-move in 2015 Rust proc macro)
 - rust-lang#117992 (Don't require intercrate mode for negative coherence)
 - rust-lang#118010 (Typeck break expr even if break is illegal)
 - rust-lang#118026 (Don't consider regions in `deref_into_dyn_supertrait` lint)
 - rust-lang#118089 (intercrate_ambiguity_causes: handle self ty infer + reservation impls)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 21, 2023
@bors
Auto merge of rust-lang#118107 - matthiaskrgr:rollup-k5bfkfr, r=matth…
baf4abf 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#117327 (Add documentation for some queries)
 - rust-lang#117835 (Note about object lifetime defaults in does not live long enough error)
 - rust-lang#117851 (Uplift `InferConst` to `rustc_type_ir`)
 - rust-lang#117973 (test: Add test for async-move in 2015 Rust proc macro)
 - rust-lang#117992 (Don't require intercrate mode for negative coherence)
 - rust-lang#118010 (Typeck break expr even if break is illegal)
 - rust-lang#118026 (Don't consider regions in `deref_into_dyn_supertrait` lint)
 - rust-lang#118089 (intercrate_ambiguity_causes: handle self ty infer + reservation impls)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7fd7dad into rust-lang:master Nov 21, 2023
@rustbot rustbot added this to the 1.76.0 milestone Nov 21, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 21, 2023
@rust-timer
Unrolled build for rust-lang#117973
cebf357 
Rollup merge of rust-lang#117973 - CohenArthur:fix-89699, r=lqd

test: Add test for async-move in 2015 Rust proc macro

Fixes rust-lang#89699

Ran cargo bisect-rustc to find when this was fixed exactly, which is in 474709a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lqd lqd lqd left review comments

Assignees

@lqd lqd

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.76.0

Development

Successfully merging this pull request may close these issues.

Compiling a Rocket application on the 2015 edition doesn't emit errors

6 participants

@CohenArthur @rustbot @lqd @rust-log-analyzer @bors @wesleywiser