Skip to content

Fix tracking issue of Windows ExitCodeExt#118218

Merged
bors merged 1 commit into
rust-lang:masterfrom
dtolnay:exitcodeext
Nov 23, 2023
Merged

Fix tracking issue of Windows ExitCodeExt#118218
bors merged 1 commit into
rust-lang:masterfrom
dtolnay:exitcodeext

Conversation

@dtolnay

@dtolnay dtolnay commented Nov 23, 2023

Copy link
Copy Markdown
Member

Tracking issue: #111688

This was left out of the initial ExitCodeExt implementation in #97917.

@rustbot

rustbot commented Nov 23, 2023

Copy link
Copy Markdown
Collaborator

r? @joshtriplett

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 23, 2023
@dtolnay

dtolnay commented Nov 23, 2023

Copy link
Copy Markdown
Member Author

@bors rollup

@compiler-errors

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Nov 23, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 52c07b9 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 23, 2023
@bors

bors commented Nov 23, 2023

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 52c07b9 with merge a1a3773...

@bors

bors commented Nov 23, 2023

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing a1a3773 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 23, 2023
@bors bors merged commit a1a3773 into rust-lang:master Nov 23, 2023
@rustbot rustbot added this to the 1.76.0 milestone Nov 23, 2023
@dtolnay dtolnay deleted the exitcodeext branch November 23, 2023 22:29
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (a1a3773): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.1% [3.1%, 3.1%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.8% [-2.8%, -2.8%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 675.669s -> 675.978s (0.05%)
Artifact size: 313.71 MiB -> 313.73 MiB (0.01%)

@dtolnay dtolnay removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. O-windows Operating system: Windows T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants