Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test for ice #113017 no entry found for key in generics_of.rs
Fixes #113017
  • Loading branch information
matthiaskrgr committed Mar 22, 2024
commit b0e10083f3f0300fda3cce292edd7b3cce5f7284
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
// test for ICE "no entry found for key" in generics_of.rs #113017

#![feature(generic_const_exprs)]
#![allow(incomplete_features)]

pub fn String<V>(elem)
//~^ ERROR expected one of `:`, `@`, or `|`, found `)`
where
V: 'a,
//~^ ERROR use of undeclared lifetime name `'a`
for<const N: usize = { || {}}> V: 'a,
//~^ ERROR use of undeclared lifetime name `'a`
//~^^ ERROR only lifetime parameters can be used in this context
//~^^^ ERROR defaults for generic parameters are not allowed in `for<...>` binders
for<C2: , R2, R3: > <&str as IntoIterator>::Item: 'static,
//~^ ERROR `&` without an explicit lifetime name cannot be used here
//~^^ ERROR only lifetime parameters can be used in this context
{}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expecct that this file is still not minimized for this ICE
and believe that most of the syntax issues don't contribute to the ICE and make it more likely this tests ends up being ineffective once we change the way we handle such errors when continuing compilation.

It would be nice to manually spend a few minutes trying to fix all unrelated errors while tracking whether the ICE still triggers.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well what you call "syntax issues" I call "additional coverage" 😄

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what I mean is, we want tests to also protect against future ICEs and minimizing everything to the absolute minimum just reduces the effectiveness in that regard

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll use the example from #113017 (comment)


pub fn main() {}
Original file line number Diff line number Diff line change
@@ -0,0 +1,92 @@
error: expected one of `:`, `@`, or `|`, found `)`
--> $DIR/ice-generics_of-no-entry-found-for-key-113017.rs:6:22
|
LL | pub fn String<V>(elem)
| ^ expected one of `:`, `@`, or `|`
|
= note: anonymous parameters are removed in the 2018 edition (see RFC 1685)
help: if this is a `self` type, give it a parameter name
|
LL | pub fn String<V>(self: elem)
| +++++
help: if this is a parameter name, give it a type
|
LL | pub fn String<V>(elem: TypeName)
| ++++++++++
help: if this is a type, explicitly ignore the parameter name
|
LL | pub fn String<V>(_: elem)
| ++

error[E0261]: use of undeclared lifetime name `'a`
--> $DIR/ice-generics_of-no-entry-found-for-key-113017.rs:9:8
|
LL | V: 'a,
| ^^ undeclared lifetime
|
= note: for more information on higher-ranked polymorphism, visit https://doc.rust-lang.org/nomicon/hrtb.html
help: consider making the bound lifetime-generic with a new `'a` lifetime
|
LL | for<'a> V: 'a,
| +++++++
help: consider introducing lifetime `'a` here
|
LL | pub fn String<'a, V>(elem)
| +++

error[E0261]: use of undeclared lifetime name `'a`
--> $DIR/ice-generics_of-no-entry-found-for-key-113017.rs:11:39
|
LL | for<const N: usize = { || {}}> V: 'a,
| ^^ undeclared lifetime
|
help: consider making the bound lifetime-generic with a new `'a` lifetime
|
LL | for<'a, const N: usize = { || {}}> V: 'a,
| +++
help: consider introducing lifetime `'a` here
|
LL | pub fn String<'a, V>(elem)
| +++

error[E0637]: `&` without an explicit lifetime name cannot be used here
--> $DIR/ice-generics_of-no-entry-found-for-key-113017.rs:15:26
|
LL | for<C2: , R2, R3: > <&str as IntoIterator>::Item: 'static,
| ^ explicit lifetime name needed here
|
help: consider introducing a higher-ranked lifetime here
|
LL | for<'a> for<C2: , R2, R3: > <&'a str as IntoIterator>::Item: 'static,
| +++++++ ++

error[E0658]: only lifetime parameters can be used in this context
--> $DIR/ice-generics_of-no-entry-found-for-key-113017.rs:11:15
|
LL | for<const N: usize = { || {}}> V: 'a,
| ^
|
= note: see issue #108185 <https://github.com/rust-lang/rust/issues/108185> for more information
= help: add `#![feature(non_lifetime_binders)]` to the crate attributes to enable
= note: this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date

error[E0658]: only lifetime parameters can be used in this context
--> $DIR/ice-generics_of-no-entry-found-for-key-113017.rs:15:9
|
LL | for<C2: , R2, R3: > <&str as IntoIterator>::Item: 'static,
| ^^ ^^ ^^
|
= note: see issue #108185 <https://github.com/rust-lang/rust/issues/108185> for more information
= help: add `#![feature(non_lifetime_binders)]` to the crate attributes to enable
= note: this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date

error: defaults for generic parameters are not allowed in `for<...>` binders
--> $DIR/ice-generics_of-no-entry-found-for-key-113017.rs:11:9
|
LL | for<const N: usize = { || {}}> V: 'a,
| ^^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to 7 previous errors

Some errors have detailed explanations: E0261, E0637, E0658.
For more information about an error, try `rustc --explain E0261`.