Skip to content

Remove check-fast. Closes #4193, #8844, #6330, #7416#12304

Closed
brson wants to merge 6 commits into
rust-lang:masterfrom
brson:check-fast
Closed

Remove check-fast. Closes #4193, #8844, #6330, #7416#12304
brson wants to merge 6 commits into
rust-lang:masterfrom
brson:check-fast

Conversation

@brson

@brson brson commented Feb 16, 2014

Copy link
Copy Markdown
Contributor

No description provided.

@huonw

huonw commented Feb 16, 2014

Copy link
Copy Markdown
Contributor

Out of interest, how long does the full test suite take to run on windows? (Also, needs a rebase.)

@alexcrichton

Copy link
Copy Markdown
Member

I, too, am curious about how this would affect cycle time. We definitely don't want cycle time to go up, so I think we should see how long the suite is on windows before merging.

@brson

brson commented Feb 16, 2014

Copy link
Copy Markdown
Contributor Author

I can run a test.

@brson

brson commented Feb 16, 2014

Copy link
Copy Markdown
Contributor Author

On win1 before removal check-fast took 16m; after, check-lite takes 24m.

@alexcrichton

Copy link
Copy Markdown
Member

That doesn't sound nearly as bad as I thought it was, but it also may push the windows bots to being the slowest bots. I think that the linux bots would be faster by 10-20min at that point. That doesn't sound too bad, and we could always slim down slower portions of the windows test suite if necessary.

@adrientetar

Copy link
Copy Markdown
Contributor

It sounds like we could largely speed-up Windows according to #8844 (comment).

@brson

brson commented Feb 16, 2014

Copy link
Copy Markdown
Contributor Author

If check-lite is not fast enough we can change it to test fewer things.

@alexcrichton

Copy link
Copy Markdown
Member

For the compile-fail test, is it possible to do // ignore-freebsd instead of // ignore-test? It would be a shame to lose them completely.

If so, r=me

klutzy referenced this pull request in klutzy/rust Mar 13, 2014
This fixes struct passing abi on x86 ffi: Structs are now passed
indirectly with byval attribute (as clang does).
@alexcrichton alexcrichton mentioned this pull request Apr 3, 2014
@alexcrichton

Copy link
Copy Markdown
Member

Closing in favor of #13288

bors added a commit that referenced this pull request Apr 7, 2014
bors added a commit that referenced this pull request Apr 7, 2014
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 25, 2022
…ents, r=jonas-schievink

minor: Include self type in generated getter/setter docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants