Stop exporting TypeckRootCtxt and FnCtxt.#123625
Merged
Merged
Conversation
Collaborator
|
r? @davidtwco rustbot has assigned @davidtwco. Use |
rustbot
added
S-waiting-on-review
Collaborator
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
oli-obk
commented
Apr 8, 2024
Comment on lines
-63
to
-64
| /// whether the cast is made in a const context or not. | ||
| pub constness: hir::Constness, |
Contributor
Author
There was a problem hiding this comment.
Also helps with the compiler telling us about unused things
fee1-dead
requested changes
Apr 8, 2024
fee1-dead
left a comment
fee1-dead
left a comment
Member
There was a problem hiding this comment.
I hope you don't mind the comment nits. r=me afterwards :)
Comment on lines
+197
to
+199
| /// If a cast from `from_ty` to `to_ty` is valid, returns an Ok containing the kind of | ||
| /// the cast. In certain cases, including some invalid casts from array references | ||
| /// to pointers, this may cause additional errors to be emitted and/or ICE error |
Member
There was a problem hiding this comment.
Suggested change
| /// If a cast from `from_ty` to `to_ty` is valid, returns an Ok containing the kind of | |
| /// the cast. In certain cases, including some invalid casts from array references | |
| /// to pointers, this may cause additional errors to be emitted and/or ICE error | |
| /// If a cast from `from_ty` to `to_ty` is valid, returns a `Some` containing the kind | |
| /// of the cast. In certain cases, including some invalid casts from array references | |
| /// to pointers, this may cause additional errors to be emitted and/or ICE error |
This returns an Option, not a Result.
|
|
||
| if let Ok(check) = CastCheck::new( | ||
| &fn_ctxt, e, from_ty, to_ty, | ||
| // We won't show any error to the user, so we don't care what the span is here. |
Member
There was a problem hiding this comment.
Suggested change
| // We won't show any error to the user, so we don't care what the span is here. | |
| // We won't show any errors to the user, so the span is irrelevant here. |
Would probably read better (I know you didn't write these but seems nice to do a drive-by)
| /// If a cast from `from_ty` to `to_ty` is valid, returns an Ok containing the kind of | ||
| /// the cast. In certain cases, including some invalid casts from array references | ||
| /// to pointers, this may cause additional errors to be emitted and/or ICE error | ||
| /// messages. This function will panic if that occurs. |
Member
There was a problem hiding this comment.
Is this really true? I don't see any panicking done in the body of this function, but I assume CastCheck wouldn't do that.
Contributor
Author
There was a problem hiding this comment.
Oh heh. I didn't read the comment at all and just copied over the function
fee1-dead
added
S-waiting-on-author
While they have many convenient APIs, it is better to expose dedicated functions for them
Contributor
Author
|
@bors r=fee1-dead |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 8, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#115984 (extending filesystem support for Hermit) - rust-lang#120144 (privacy: Stabilize lint `unnameable_types`) - rust-lang#122807 (Add consistency with phrases "meantime" and "mean time") - rust-lang#123089 (Add invariant to VecDeque::pop_* that len < cap if pop successful) - rust-lang#123595 (Documentation fix) - rust-lang#123625 (Stop exporting `TypeckRootCtxt` and `FnCtxt`.) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 8, 2024
Rollup merge of rust-lang#123625 - oli-obk:private_fnctxt, r=fee1-dead Stop exporting `TypeckRootCtxt` and `FnCtxt`. While they have many convenient APIs, it is better to expose dedicated functions for them noticed in rust-lang#122213
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 18, 2024
Stop exporting `TypeckRootCtxt` and `FnCtxt`. While they have many convenient APIs, it is better to expose dedicated functions for them noticed in rust-lang#122213
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While they have many convenient APIs, it is better to expose dedicated functions for them
noticed in #122213