Skip to content

crashes: add a couple more ice tests#124038

Merged
bors merged 1 commit into
rust-lang:masterfrom
matthiaskrgr:one_or_two_more_tests
Apr 19, 2024
Merged

crashes: add a couple more ice tests#124038
bors merged 1 commit into
rust-lang:masterfrom
matthiaskrgr:one_or_two_more_tests

Conversation

@matthiaskrgr

@matthiaskrgr matthiaskrgr commented Apr 16, 2024

Copy link
Copy Markdown
Member

No description provided.

@rustbot

rustbot commented Apr 16, 2024

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 16, 2024
jieyouxu
jieyouxu approved these changes Apr 16, 2024
View reviewed changes

@jieyouxu jieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to r=me after CI is green.

@matthiaskrgr

matthiaskrgr commented Apr 16, 2024

Copy link
Copy Markdown
Member Author

well the crux is that some of the may not crash on all of the targets so it's always a gamble (the first pr needed like 5-7 retries :( to figure out all the test failures / unintended none-ICEs)

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@matthiaskrgr matthiaskrgr force-pushed the one_or_two_more_tests branch from 308ea64 to ce73f55 Compare April 16, 2024 20:19
@jieyouxu

jieyouxu commented Apr 16, 2024

Copy link
Copy Markdown
Member

well the crux is that some of the may not crash on all of the targets so it's always a gamble (the first pr needed like 5-7 retries :( to figure out all the test failures / unintended none-ICEs)

Yeah, good luck :3

@jieyouxu

jieyouxu commented Apr 16, 2024

Copy link
Copy Markdown
Member

@bors rollup=iffy

@matthiaskrgr

matthiaskrgr commented Apr 16, 2024

Copy link
Copy Markdown
Member Author

@bors r=jieyouxu

@bors

bors commented Apr 16, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit ce73f55 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 16, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 17, 2024
@bors
Auto merge of rust-lang#124038 - matthiaskrgr:one_or_two_more_tests, …
4d51e71 
…r=jieyouxu

crashes: add a couple more ice tests
@bors

bors commented Apr 17, 2024

Copy link
Copy Markdown
Collaborator

⌛ Testing commit ce73f55 with merge 4d51e71...

@bors

bors commented Apr 18, 2024

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 18, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 18, 2024
@bors
Auto merge of rust-lang#124046 - matthiaskrgr:one_or_two_more_tests__…
7e3a6e7 
…__some_on_top, r=jieyouxu

crashes: add even more tests?!?

adds more tests that were not already added with rust-lang#124038 from the past 10 months or so.
Need a couple more passes through the tracker to filter out more missing ice /fixed tests but we're slowly getting there.
@matthiaskrgr

matthiaskrgr commented Apr 18, 2024

Copy link
Copy Markdown
Member Author

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2024
@bors

bors commented Apr 18, 2024

Copy link
Copy Markdown
Collaborator

⌛ Testing commit ce73f55 with merge 8cd77da...

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 18, 2024
@bors
Auto merge of rust-lang#124038 - matthiaskrgr:one_or_two_more_tests, …
8cd77da 
…r=jieyouxu

crashes: add a couple more ice tests
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors

bors commented Apr 18, 2024

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 18, 2024
@bors bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 18, 2024
@matthiaskrgr matthiaskrgr force-pushed the one_or_two_more_tests branch from e7f5540 to d78a004 Compare April 18, 2024 12:36
@matthiaskrgr

matthiaskrgr commented Apr 18, 2024

Copy link
Copy Markdown
Member Author

@bors r=jieyouxu

@bors

bors commented Apr 18, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit d78a004 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2024
@bors

bors commented Apr 18, 2024

Copy link
Copy Markdown
Collaborator

⌛ Testing commit d78a004 with merge ad08de5...

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 18, 2024
@bors
Auto merge of rust-lang#124038 - matthiaskrgr:one_or_two_more_tests, …
ad08de5 
…r=jieyouxu

crashes: add a couple more ice tests
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors

bors commented Apr 18, 2024

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 18, 2024
@matthiaskrgr matthiaskrgr force-pushed the one_or_two_more_tests branch from d78a004 to e7f9ee2 Compare April 18, 2024 15:40
@matthiaskrgr

matthiaskrgr commented Apr 18, 2024

Copy link
Copy Markdown
Member Author

maybe the test needs needs-llvm-components: x86?

@bors r=jieyouxu

@bors

bors commented Apr 18, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit e7f9ee2 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@matthiaskrgr matthiaskrgr force-pushed the one_or_two_more_tests branch from e7f9ee2 to 1d45b7a Compare April 18, 2024 16:55
@matthiaskrgr

matthiaskrgr commented Apr 18, 2024

Copy link
Copy Markdown
Member Author

@bors r=jieyouxu

@bors

bors commented Apr 18, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 1d45b7a has been approved by jieyouxu

It is now in the queue for this repository.

@bors

bors commented Apr 19, 2024

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1d45b7a with merge fa0068b...

@bors

bors commented Apr 19, 2024

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing fa0068b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 19, 2024
@bors bors merged commit fa0068b into rust-lang:master Apr 19, 2024
@rustbot rustbot added this to the 1.79.0 milestone Apr 19, 2024
@rust-timer

rust-timer commented Apr 19, 2024

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (fa0068b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.7% [0.7%, 0.7%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.7% [0.7%, 0.7%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 673.694s -> 673.311s (-0.06%)
Artifact size: 315.28 MiB -> 315.21 MiB (-0.02%)

github-actions Bot pushed a commit to rust-lang/miri that referenced this pull request Apr 19, 2024
@bors
Auto merge of #124046 - matthiaskrgr:one_or_two_more_tests____some_on…
e84e0bd 
…_top, r=jieyouxu

crashes: add even more tests?!?

adds more tests that were not already added with rust-lang/rust#124038 from the past 10 months or so.
Need a couple more passes through the tracker to filter out more missing ice /fixed tests but we're slowly getting there.
@matthiaskrgr matthiaskrgr deleted the one_or_two_more_tests branch January 25, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.79.0

Development

Successfully merging this pull request may close these issues.

7 participants

@matthiaskrgr @rustbot @rust-log-analyzer @jieyouxu @bors @rust-timer @Mark-Simulacrum