Refactor Apple target_abi#124762
Conversation
This was bundled together with `Arch`, which complicated a few code paths and meant we had to do more string matching than necessary.
|
These commits modify compiler targets. |
|
looking through this, pretty certain that this doesn't do any functional changes (so r=me on that front). Unsure whether this split is generally desirable/the state of apple abis more generally r? compiler |
BlackHoleFox
left a comment
There was a problem hiding this comment.
Not a t-compiler member but just as someone who works on these files a lot this is an improvement in many ways. Especially the removal of macabi being hardcoded in too many places.
|
lcnr says there are no functional changes, BlackHoleFox thinks this is an improvement, that sounds good. |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (2259028): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 675.209s -> 673.288s (-0.28%) |
This was bundled together with
Arch, which complicated a few code paths and meant we had to do more string matching than necessary.CC @BlackHoleFox as you've worked on the Apple target spec before
Related: Is there a reason why
Target/TargetOptionsuseStaticCowfor so many things, instead of an enum with defined values (and perhaps a catch-all case for custom target json files)? Tagging @Nilstrieb, as you might know?