Add a run-make test that LLD is not being used by default on the x64 beta/stable channel by Kobzol · Pull Request #127081 · rust-lang/rust

Kobzol · 2024-06-28T10:21:16Z

#126701 showed that the handling of lld in bootstrap is currently not ideal. While it would be nice to refactor it eventually, we should also make sure that we have a test that checks that lld is not used (yet!) by default on the x64 Linux stable channel.

CC @lqd

r? @onur-ozkan

bors · 2024-06-28T23:09:02Z

☔ The latest upstream changes (presumably #126701) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot · 2024-06-29T06:41:30Z

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

Kobzol · 2024-06-29T06:41:38Z

Rebased.

@rustbot ready

tests/run-make/rust-lld-by-default-stable/rmake.rs

Kobzol · 2024-06-29T07:01:45Z

Switched the test to ignore-nightly.

onur-ozkan · 2024-06-29T07:05:40Z

Since it's no longer stable channel specific, should we update the test name?

Kobzol · 2024-06-29T07:10:17Z

beta-stable?

onur-ozkan · 2024-06-29T07:18:03Z

beta-stable?

Yeah, this sounds good.

Kobzol · 2024-06-29T07:19:41Z

Ok, done.

onur-ozkan · 2024-06-29T07:26:12Z

Awesome!

@bors r+

bors · 2024-06-29T07:26:14Z

📌 Commit ac385e3 has been approved by onur-ozkan

It is now in the queue for this repository.

tests/run-make/rust-lld-by-default-beta-stable/rmake.rs

…beta/stable channel

Kobzol · 2024-06-29T08:11:52Z

I fixed the comment based on lqd's suggestion. I'll wait for #127081 (comment) until reapproving.

@bors r-

Kobzol · 2024-06-29T08:17:48Z

@bors r=onur-ozkan

bors · 2024-06-29T08:17:51Z

📌 Commit 4442fd7 has been approved by onur-ozkan

It is now in the queue for this repository.

Add a run-make test that LLD is not being used by default on the x64 beta/stable channel rust-lang#126701 showed that the handling of `lld` in bootstrap is currently not ideal. While it would be nice to refactor it eventually, we should also make sure that we have a test that checks that `lld` is not used (yet!) by default on the x64 Linux stable channel. CC `@lqd` r? `@onur-ozkan`

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#123237 (Various rustc_codegen_ssa cleanups) - rust-lang#126960 (Improve error message in tidy) - rust-lang#127002 (Implement `x perf` as a separate tool) - rust-lang#127050 (Make mtime of reproducible tarballs dependent on git commit) - rust-lang#127081 (Add a run-make test that LLD is not being used by default on the x64 beta/stable channel) - rust-lang#127106 (Improve unsafe extern blocks diagnostics) - rust-lang#127110 (Fix a error suggestion for E0121 when using placeholder _ as return types on function signature.) - rust-lang#127114 (fix: prefer `(*p).clone` to `p.clone` if the `p` is a raw pointer) - rust-lang#127118 (Show `used attribute`'s kind for user when find it isn't applied to a `static` variable.) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#123237 (Various rustc_codegen_ssa cleanups) - rust-lang#126960 (Improve error message in tidy) - rust-lang#127002 (Implement `x perf` as a separate tool) - rust-lang#127081 (Add a run-make test that LLD is not being used by default on the x64 beta/stable channel) - rust-lang#127106 (Improve unsafe extern blocks diagnostics) - rust-lang#127110 (Fix a error suggestion for E0121 when using placeholder _ as return types on function signature.) - rust-lang#127114 (fix: prefer `(*p).clone` to `p.clone` if the `p` is a raw pointer) - rust-lang#127118 (Show `used attribute`'s kind for user when find it isn't applied to a `static` variable.) - rust-lang#127122 (Remove uneccessary condition in `div_ceil`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#127081 - Kobzol:lld-test, r=onur-ozkan Add a run-make test that LLD is not being used by default on the x64 beta/stable channel rust-lang#126701 showed that the handling of `lld` in bootstrap is currently not ideal. While it would be nice to refactor it eventually, we should also make sure that we have a test that checks that `lld` is not used (yet!) by default on the x64 Linux stable channel. CC ``@lqd`` r? ``@onur-ozkan``

rustbot assigned onur-ozkan Jun 28, 2024

rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2024

Kobzol force-pushed the lld-test branch from 174f217 to 8aa4145 Compare June 29, 2024 06:41

Kobzol marked this pull request as ready for review June 29, 2024 06:41

onur-ozkan reviewed Jun 29, 2024

View reviewed changes

tests/run-make/rust-lld-by-default-stable/rmake.rs Show resolved Hide resolved

Kobzol force-pushed the lld-test branch from 8aa4145 to 3a640f1 Compare June 29, 2024 07:01

Kobzol force-pushed the lld-test branch from 3a640f1 to ac385e3 Compare June 29, 2024 07:19

Kobzol changed the title ~~Add a run-make test that LLD is not being used by default on the x64 stable channel~~ Add a run-make test that LLD is not being used by default on the x64 beta/stable channel Jun 29, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2024

lqd reviewed Jun 29, 2024

View reviewed changes

tests/run-make/rust-lld-by-default-beta-stable/rmake.rs Outdated Show resolved Hide resolved

Add a run-make test that LLD is not being used by default on the x64 …

4442fd7

…beta/stable channel

Kobzol force-pushed the lld-test branch from ac385e3 to 4442fd7 Compare June 29, 2024 08:11

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 29, 2024

bors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 29, 2024

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 29, 2024

matthiaskrgr mentioned this pull request Jun 29, 2024

Rollup of 9 pull requests #127125

Closed

matthiaskrgr mentioned this pull request Jun 29, 2024

Rollup of 9 pull requests #127133

Merged

bors merged commit fafb2ea into rust-lang:master Jun 30, 2024

rustbot added this to the 1.81.0 milestone Jun 30, 2024

Kobzol deleted the lld-test branch June 30, 2024 05:17

Uh oh!

Conversation

Kobzol commented Jun 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Jun 28, 2024

Uh oh!

rustbot commented Jun 29, 2024

Uh oh!

Kobzol commented Jun 29, 2024

Uh oh!

Uh oh!

Kobzol commented Jun 29, 2024

Uh oh!

onur-ozkan commented Jun 29, 2024

Uh oh!

Kobzol commented Jun 29, 2024

Uh oh!

onur-ozkan commented Jun 29, 2024

Uh oh!

Kobzol commented Jun 29, 2024

Uh oh!

onur-ozkan commented Jun 29, 2024

Uh oh!

bors commented Jun 29, 2024

Uh oh!

Uh oh!

Kobzol commented Jun 29, 2024

Uh oh!

Kobzol commented Jun 29, 2024

Uh oh!

bors commented Jun 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Kobzol commented Jun 28, 2024 •

edited

Loading