doc: Make block of inline Deref methods foldable by tesuji · Pull Request #127474 · rust-lang/rust

tesuji · 2024-07-08T03:24:54Z

After:

Before:

Current status:

Bug when hovering over title "Methods from ...": The anchor sign $ overlaps with [-]: doc: Make block of inline Deref methods foldable #127474 (comment)
=> Fixed by doc: Make block of inline Deref methods foldable #127474 (comment)

rustbot · 2024-07-08T03:25:02Z

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

GuillaumeGomez · 2024-07-08T13:07:36Z

The [-]/[+] sign is not aligned with the title right?

rustbot · 2024-07-08T17:39:13Z

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha

tesuji · 2024-07-08T17:41:31Z

The [-]/[+] sign is not aligned with the title right?

Yeah, that was true since I am not really familiar with CSS. But I found the trick in 0fdb788
After:

GuillaumeGomez · 2024-07-11T13:22:12Z

There is also this bug:

GuillaumeGomez · 2024-07-11T14:31:13Z

If it's fine with you, I can make changes so all UI bugs are fixed?

tesuji · 2024-07-11T21:51:46Z

I'm glad you offer the help. CSS is really not my expertise.

rustbot · 2024-07-15T16:11:11Z

Some changes occurred in GUI tests.

cc @GuillaumeGomez

GuillaumeGomez · 2024-07-15T16:14:48Z

Changed the display, it now looks like this:

And on mobile, since there is no hover, it gets back to its original X position:

I'm not too fond of having to move the [-] sign to the left like this but it's the only way I could find to allow to have this feature without preventing the anchor to work...

Sadly, it seems like I can't publish doc with this feature since rustdoc.crud.net seems down.

Anyway, let's set another reviewer.

r? @notriddle

GuillaumeGomez · 2024-07-15T18:07:32Z

And fixed tidy...

notriddle · 2024-07-15T22:17:36Z

@rfcbot fcp merge

rfcbot · 2024-07-15T22:17:39Z

Team member @notriddle has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot · 2024-08-22T16:19:59Z

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot · 2024-09-01T16:20:24Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

GuillaumeGomez · 2024-09-01T16:25:23Z

@bors r=t-rustdoc rollup

bors · 2024-09-01T16:25:25Z

📌 Commit 9855a38 has been approved by t-rustdoc

It is now in the queue for this repository.

…-rustdoc doc: Make block of inline Deref methods foldable After: ![image](https://github.com/rust-lang/rust/assets/15225902/3e8ab320-dbf7-436f-9be0-d0ef82664663) Before: ![image](https://github.com/rust-lang/rust/assets/15225902/f6f7635d-d4c3-437e-a2d9-147726287b05) Fix rust-lang#127470. Current status: - [x] Bug when hovering over title "Methods from ...": The anchor sign $ overlaps with `[-]`: rust-lang#127474 (comment) => Fixed by rust-lang#127474 (comment)

…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#127474 (doc: Make block of inline Deref methods foldable) - rust-lang#129624 (Adjust `memchr` pinning and run `cargo update`) - rust-lang#129678 (Deny imports of `rustc_type_ir::inherent` outside of type ir + new trait solver) - rust-lang#129837 (Actually parse stdout json, instead of using hacky contains logic.) - rust-lang#129842 (Fix LLVM ABI NAME for riscv64imac-unknown-nuttx-elf) - rust-lang#129843 (Mark myself as on vacation for triagebot) - rust-lang#129858 (Replace walk with visit so we dont skip outermost expr kind in def collector) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#127474 (doc: Make block of inline Deref methods foldable) - rust-lang#129678 (Deny imports of `rustc_type_ir::inherent` outside of type ir + new trait solver) - rust-lang#129738 (`rustc_mir_transform` cleanups) - rust-lang#129793 (add extra linebreaks so rustdoc can identify the first sentence) - rust-lang#129804 (Fixed some typos in the standard library documentation/comments) - rust-lang#129837 (Actually parse stdout json, instead of using hacky contains logic.) - rust-lang#129842 (Fix LLVM ABI NAME for riscv64imac-unknown-nuttx-elf) - rust-lang#129843 (Mark myself as on vacation for triagebot) - rust-lang#129858 (Replace walk with visit so we dont skip outermost expr kind in def collector) Failed merges: - rust-lang#129777 (Add `unreachable_pub`, round 4) - rust-lang#129868 (Remove kobzol vacation status) r? `@ghost` `@rustbot` modify labels: rollup

…-rustdoc doc: Make block of inline Deref methods foldable After: ![image](https://github.com/rust-lang/rust/assets/15225902/3e8ab320-dbf7-436f-9be0-d0ef82664663) Before: ![image](https://github.com/rust-lang/rust/assets/15225902/f6f7635d-d4c3-437e-a2d9-147726287b05) Fix rust-lang#127470. Current status: - [x] Bug when hovering over title "Methods from ...": The anchor sign $ overlaps with `[-]`: rust-lang#127474 (comment) => Fixed by rust-lang#127474 (comment)

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#127474 (doc: Make block of inline Deref methods foldable) - rust-lang#129678 (Deny imports of `rustc_type_ir::inherent` outside of type ir + new trait solver) - rust-lang#129738 (`rustc_mir_transform` cleanups) - rust-lang#129793 (add extra linebreaks so rustdoc can identify the first sentence) - rust-lang#129804 (Fixed some typos in the standard library documentation/comments) - rust-lang#129837 (Actually parse stdout json, instead of using hacky contains logic.) - rust-lang#129842 (Fix LLVM ABI NAME for riscv64imac-unknown-nuttx-elf) - rust-lang#129843 (Mark myself as on vacation for triagebot) - rust-lang#129858 (Replace walk with visit so we dont skip outermost expr kind in def collector) Failed merges: - rust-lang#129777 (Add `unreachable_pub`, round 4) - rust-lang#129868 (Remove kobzol vacation status) r? `@ghost` `@rustbot` modify labels: rollup

…kingjubilee Rollup of 11 pull requests Successful merges: - rust-lang#127021 (Add target support for RTEMS Arm) - rust-lang#127474 (doc: Make block of inline Deref methods foldable) - rust-lang#129624 (Adjust `memchr` pinning and run `cargo update`) - rust-lang#129678 (Deny imports of `rustc_type_ir::inherent` outside of type ir + new trait solver) - rust-lang#129738 (`rustc_mir_transform` cleanups) - rust-lang#129793 (add extra linebreaks so rustdoc can identify the first sentence) - rust-lang#129804 (Fixed some typos in the standard library documentation/comments) - rust-lang#129837 (Actually parse stdout json, instead of using hacky contains logic.) - rust-lang#129842 (Fix LLVM ABI NAME for riscv64imac-unknown-nuttx-elf) - rust-lang#129843 (Mark myself as on vacation for triagebot) - rust-lang#129858 (Replace walk with visit so we dont skip outermost expr kind in def collector) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#127474 (doc: Make block of inline Deref methods foldable) - rust-lang#129678 (Deny imports of `rustc_type_ir::inherent` outside of type ir + new trait solver) - rust-lang#129738 (`rustc_mir_transform` cleanups) - rust-lang#129793 (add extra linebreaks so rustdoc can identify the first sentence) - rust-lang#129804 (Fixed some typos in the standard library documentation/comments) - rust-lang#129837 (Actually parse stdout json, instead of using hacky contains logic.) - rust-lang#129842 (Fix LLVM ABI NAME for riscv64imac-unknown-nuttx-elf) - rust-lang#129843 (Mark myself as on vacation for triagebot) - rust-lang#129858 (Replace walk with visit so we dont skip outermost expr kind in def collector) Failed merges: - rust-lang#129777 (Add `unreachable_pub`, round 4) - rust-lang#129868 (Remove kobzol vacation status) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#127474 - tesuji:foldable-inline-derefs, r=t-rustdoc doc: Make block of inline Deref methods foldable After: ![image](https://github.com/rust-lang/rust/assets/15225902/3e8ab320-dbf7-436f-9be0-d0ef82664663) Before: ![image](https://github.com/rust-lang/rust/assets/15225902/f6f7635d-d4c3-437e-a2d9-147726287b05) Fix rust-lang#127470. Current status: - [x] Bug when hovering over title "Methods from ...": The anchor sign $ overlaps with `[-]`: rust-lang#127474 (comment) => Fixed by rust-lang#127474 (comment)

rustbot assigned GuillaumeGomez Jul 8, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 8, 2024

This comment has been minimized.

Sign in to view

tesuji force-pushed the foldable-inline-derefs branch from 0fdb788 to c71ffcc Compare July 8, 2024 17:50

tesuji changed the title ~~doc: Fold inline methods from Deref~~ doc: Make bloc of inline Deref methods foldable Jul 10, 2024

tesuji changed the title ~~doc: Make bloc of inline Deref methods foldable~~ doc: Make block of inline Deref methods foldable Jul 10, 2024

tesuji and others added 3 commits July 15, 2024 17:44

doc: Fold inline methods from Deref

315a16f

Fix style

fbc794f

Create new CSS class for "big toggles"

a868b3f

GuillaumeGomez force-pushed the foldable-inline-derefs branch from c71ffcc to 3855aa7 Compare July 15, 2024 16:11

rustbot assigned notriddle and unassigned GuillaumeGomez Jul 15, 2024

This comment has been minimized.

Sign in to view

notriddle added T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. and removed T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 15, 2024

Add tests for new toggle on deref blocks

9855a38

GuillaumeGomez force-pushed the foldable-inline-derefs branch from 3855aa7 to 9855a38 Compare July 15, 2024 18:07

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 15, 2024

rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Aug 22, 2024

rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Aug 22, 2024

rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Sep 1, 2024

rfcbot added the to-announce Announce this issue on triage meeting label Sep 1, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2024

GuillaumeGomez mentioned this pull request Sep 1, 2024

Rollup of 7 pull requests #129862

Closed

matthiaskrgr mentioned this pull request Sep 2, 2024

Rollup of 9 pull requests #129873

Merged

workingjubilee mentioned this pull request Sep 2, 2024

Rollup of 11 pull requests #129879

Closed

bors merged commit c90991d into rust-lang:master Sep 2, 2024

rustbot added this to the 1.83.0 milestone Sep 2, 2024

tesuji deleted the foldable-inline-derefs branch September 3, 2024 17:27

apiraino removed the to-announce Announce this issue on triage meeting label Sep 5, 2024

Uh oh!

Conversation

tesuji commented Jul 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 8, 2024

Uh oh!

GuillaumeGomez commented Jul 8, 2024

Uh oh!

rustbot commented Jul 8, 2024

Uh oh!

tesuji commented Jul 8, 2024

Uh oh!

This comment has been minimized.

GuillaumeGomez commented Jul 11, 2024

Uh oh!

GuillaumeGomez commented Jul 11, 2024

Uh oh!

tesuji commented Jul 11, 2024

Uh oh!

rustbot commented Jul 15, 2024

Uh oh!

GuillaumeGomez commented Jul 15, 2024

Uh oh!

This comment has been minimized.

GuillaumeGomez commented Jul 15, 2024

Uh oh!

notriddle commented Jul 15, 2024

Uh oh!

rfcbot commented Jul 15, 2024 • edited by camelid Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rfcbot commented Aug 22, 2024

Uh oh!

rfcbot commented Sep 1, 2024

Uh oh!

GuillaumeGomez commented Sep 1, 2024

Uh oh!

bors commented Sep 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

tesuji commented Jul 8, 2024 •

edited

Loading

rfcbot commented Jul 15, 2024 •

edited by camelid

Loading