check type error recursively in typeck#128670
Closed
adwinwhite wants to merge 1 commit intorust-lang:masterfrom
Closed
check type error recursively in typeck#128670adwinwhite wants to merge 1 commit intorust-lang:masterfrom
adwinwhite wants to merge 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
r? @nnethercote rustbot has assigned @nnethercote. Use |
rustbot
added
S-waiting-on-review
Contributor
|
I don't know much about type checking and @compiler-errors reviewed #122749, which apparently caused #127742, so: r? compiler-errors |
This comment has been minimized.
This comment has been minimized.
adwinwhite
force-pushed
the
recursive_visit
branch
from
d5a99f3 to
5d944e1
Compare
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
|
I'm not getting a great feeling from this approach. It seems like a very heavy hammer, and I'd first like to see a detailed analysis for why #127742 ICEs in the first place. |
Contributor
|
@rustbot author |
rustbot
added
S-waiting-on-author
Contributor
Author
|
I realized my solution is quite naive too, during solving the stack overflow bug. The nested types can get really deep to traversal. Anyway, a more detailed ICE analysis is added under the issue. |
Contributor
Author
|
A more correct approach might be adding a But then we would run into Perhaps I should close this as duplicated with #113125. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent types that contains error from passing typeck and causing error in const eval later.
Type visitor doesn't visit fields of ADT thus cannot detect error in them. So I created a custom visitor to allow recursive visiting.
Fixes #127742.