rustc: test: don't silently ignore bad benches#13000
rustc: test: don't silently ignore bad benches#13000emberian wants to merge 1 commit intorust-lang:masterfrom emberian:typeck-bench
Conversation
|
This looks good to me, but I don't think it closes #12997 because it still doesn't typecheck the signature. All it's doing is making sure that it's the right number of arguments. r=me if you change the PR description and commit message to not close the issue |
|
It's already typechecked if the function modified here passes. See the PR On Tue, Mar 18, 2014 at 11:09 AM, Alex Crichton notifications@github.comwrote:
|
|
Oops, sorry about that! Could you add a test for that as well? |
This is adequate because when a function has a type that isn't caught here,
that is, it has a single argument, but it *isn't* `&mut BenchHarness`, it
errors later on with:
error: mismatched types: expected `fn(&mut test::BenchHarness)` but found
`fn(int)` (expected &-ptr but found int)
which I consider acceptable.
Closes #12997
|
@alexcrichton r? added test |
Take into account renamed extension id when launching
2 participants
This is adequate because when a function has a type that isn't caught here,
that is, it has a single argument, but it isn't
&mut BenchHarness, iterrors later on with:
which I consider acceptable.
Closes #12997