Never patterns constitute a read for unsafety#130533
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 19, 2024
Merged
Conversation
rustbot
added
S-waiting-on-review
compiler-errors
force-pushed
the
never-pat-unsafeck
branch
from
9afdab5 to
e138e87
Compare
Member
|
Oh wow yep, good catch @bors r+ |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 19, 2024
…kingjubilee Rollup of 3 pull requests Successful merges: - rust-lang#130531 (Check params for unsafety in THIR) - rust-lang#130533 (Never patterns constitute a read for unsafety) - rust-lang#130542 (Stabilize const `MaybeUninit::as_mut_ptr`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 19, 2024
Rollup merge of rust-lang#130533 - compiler-errors:never-pat-unsafeck, r=Nadrieril Never patterns constitute a read for unsafety This code is otherwise unsound if we don't emit an unsafety error here. Noticed when fixing rust-lang#130528, but it's totally unrelated. r? `@Nadrieril`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code is otherwise unsound if we don't emit an unsafety error here. Noticed when fixing #130528, but it's totally unrelated.
r? @Nadrieril