update "build/host" symlink comment#131279
Conversation
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
S-waiting-on-review
onur-ozkan
force-pushed
the
remove-host-symlink
branch
from
85f1a4d to
d9cbd7e
Compare
|
what's the motivation? this seems like a small thing that makes it easier to work with bootstrap with no downsides other than a bit of easy to maintain code. or is there more to it? |
It says |
How does it make things easier? The host target is always the same and they are at the same directory level. You just need to type the first couple of letters of the host triple and press TAB instead of writing 'host'. |
|
that was just a vague feeling, but it doesn't matter, I just remembered that we rely on this for the rust analyzer config: rust/src/etc/rust_analyzer_settings.json Line 21 in e561499 |
|
I use build/host all the time. Please don't remove it for literally no reason, lmao. |
Nice. It seems more useful than "writing consistent docs". I will revert the removal and update the doc. |
Signed-off-by: onur-ozkan <work@onurozkan.dev>
onur-ozkan
force-pushed
the
remove-host-symlink
branch
from
d9cbd7e to
4f50efd
Compare
onur-ozkan
changed the title
|
cool! |
bors
added
S-waiting-on-bors
|
(I updated the PR description for you) |
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#129392 (Do not consider match/let/ref of place that evaluates to `!` to diverge, disallow coercions from them too) - rust-lang#131279 (update "build/host" symlink comment) - rust-lang#131312 (On function and method calls in patterns, link to the book) - rust-lang#131315 (bootstrap: add `std_features` config) - rust-lang#131316 (Fix typo in primitive_docs.rs) r? `@ghost` `@rustbot` modify labels: rollup
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#129392 (Do not consider match/let/ref of place that evaluates to `!` to diverge, disallow coercions from them too) - rust-lang#131279 (update "build/host" symlink comment) - rust-lang#131312 (On function and method calls in patterns, link to the book) - rust-lang#131315 (bootstrap: add `std_features` config) - rust-lang#131316 (Fix typo in primitive_docs.rs) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#131279 - onur-ozkan:remove-host-symlink, r=Noratrieb update "build/host" symlink comment It's needed and can't be removed, so make it clear where it's needed.
6 participants
It's needed and can't be removed, so make it clear where it's needed.