compiler: use is_none_or where it is clearly better#131815
Merged
Merged
Conversation
heuristic was: if it easily allows removing bangs entirely? worth it. if it requires more effort or just moves the bang? not.
Collaborator
|
rustbot has assigned @petrochenkov. Use |
rustbot
added
S-waiting-on-review
jieyouxu
approved these changes
Oct 17, 2024
jieyouxu
left a comment
jieyouxu
left a comment
Member
There was a problem hiding this comment.
Seems reasonable to me. You can r=me after PR CI is green.
Member
Author
|
@bors r=jieyouxu |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 17, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#128391 (Change orphan hint from "only" to "any uncovered type inside...") - rust-lang#131583 (Setting up indirect access to external data for loongarch64-linux-{musl,ohos}) - rust-lang#131595 (rustdoc-JSON: Rename "object safe" to "dyn compatible") - rust-lang#131748 (cleanup canonical queries) - rust-lang#131798 (llvm: Tolerate propagated range metadata) - rust-lang#131815 (compiler: use `is_none_or` where it is clearly better) - rust-lang#131822 (extract `expr_assign_expected_bool_error`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 17, 2024
Rollup merge of rust-lang#131815 - workingjubilee:did-you-mean-is-none-or, r=jieyouxu compiler: use `is_none_or` where it is clearly better heuristic was: if it easily allows removing bangs entirely? worth it. if it requires more effort or just moves the bang? not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
heuristic was: if it easily allows removing bangs entirely? worth it. if it requires more effort or just moves the bang? not.