[rustdoc] Do not consider nested functions as main function even if named main in doctests#132105
Merged
Merged
Conversation
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
doctest-nested-main
branch
from
006d5d1 to
d51fe6e
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
doctest-nested-main
branch
from
b559eba to
942b449
Compare
notriddle
reviewed
Oct 24, 2024
| ast::ItemKind::Fn(ref fn_item) if !info.has_main_fn => { | ||
| if item.ident.name == sym::main { | ||
| info.has_main_fn = true; | ||
| info.has_main_fn = is_top_level; |
Contributor
There was a problem hiding this comment.
Suggested change
| info.has_main_fn = is_top_level; | |
| info.has_main_fn = info.has_main_fn || is_top_level; |
Also, please add this test case
/// ```
/// fn main() {
/// fn main() {}
/// }
/// ```
GuillaumeGomez
force-pushed
the
doctest-nested-main
branch
from
942b449 to
aab2b67
Compare
Contributor
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 25, 2024
…r=notriddle [rustdoc] Do not consider nested functions as main function even if named `main` in doctests Fixes rust-lang#131893. If a nested function is called `main`, it is not considered as the entry point of the program. Therefore, doctests should not consider such functions as such either. r? `@notriddle`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 25, 2024
…r=notriddle [rustdoc] Do not consider nested functions as main function even if named `main` in doctests Fixes rust-lang#131893. If a nested function is called `main`, it is not considered as the entry point of the program. Therefore, doctests should not consider such functions as such either. r? `@notriddle`
Collaborator
Member
|
Something about the queue is really messed up, I'll do a resync |
This comment was marked as outdated.
This comment was marked as outdated.
bors
added
S-waiting-on-author
This comment was marked as outdated.
This comment was marked as outdated.
bors
added
S-waiting-on-author
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
bors
added
S-waiting-on-bors
Member
|
??? Does editing the treeclosed comment reopen the tree |
Member
|
It's as if this PR is still being tested, so to be safe: |
bors
added
S-waiting-on-author
Member
|
@bors r- |
bors
added
S-waiting-on-author
Member
Collaborator
Collaborator
|
🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
Member
|
Seems to have finished resyncing, so |
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Member
Author
|
Should we backport it? |
Collaborator
|
Finished benchmarking commit (017ae1b): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary 2.4%, secondary 3.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 783.653s -> 781.857s (-0.23%) |
Contributor
I wouldn't. There's a very easy workaround, it went a long time without anyone hitting the bug, and it causes a failed compile instead of something worse (like a miscompile or a spurious test pass). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #131893.
If a nested function is called
main, it is not considered as the entry point of the program. Therefore, doctests should not consider such functions as such either.r? @notriddle