Skip to content

Misc. rustc_hir cleanups 🧹 #136219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 6 commits into from
Feb 7, 2025
Merged

Misc. rustc_hir cleanups 🧹 #136219

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0baa100
rustc_hir: replace `is_empty()`+indexing with `first()`
yotamofek Jan 28, 2025
3802225
rustc_hir: use box patterns to flatten some nested pattern matches
yotamofek Jan 28, 2025
1d4a419
rustc_hir: don't open-code `Iterator::eq`
yotamofek Jan 28, 2025
8aba730
rustc_hir: fix typo in comment
yotamofek Jan 28, 2025
6c1df36
rustc_hir: flatten nested `if`s
yotamofek Jan 28, 2025
056fe96
rustc_hir: remove some uneeded refs and derefs
yotamofek Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
rustc_hir: replace is_empty()+indexing with first()
  • Loading branch information
@yotamofek
yotamofek committed Jan 28, 2025
commit 0baa1007100fd72ec6c2b5760e3df74bd4da3fa1
2 changes: 1 addition & 1 deletion compiler/rustc_hir/src/hir.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ pub type UsePath<'hir> = Path<'hir, SmallVec<[Res; 3]>>;

impl Path<'_> {
pub fn is_global(&self) -> bool {
!self.segments.is_empty() && self.segments[0].ident.name == kw::PathRoot
self.segments.first().is_some_and(|segment| segment.ident.name == kw::PathRoot)
}
}

Expand Down