Fix/tweak some tests in new solver#138838
Merged
bors merged 4 commits intorust-lang:masterfrom Mar 25, 2025
Merged
Conversation
rustbot
added
S-waiting-on-review
lcnr
reviewed
Mar 23, 2025
| ty::PredicateKind::Subtype { .. } | ty::PredicateKind::AliasRelate(..) => {} | ||
| ty::PredicateKind::Subtype { .. } | ||
| | ty::PredicateKind::AliasRelate(..) | ||
| | ty::PredicateKind::Clause(ty::ClauseKind::WellFormed(_)) => {} |
Contributor
There was a problem hiding this comment.
WellFormed is required to constrain bivariant parameters
idk whether this should be productive, cc rust-lang/trait-system-refactor-initiative#169
can you add a FIXME(-Znext-solver=coinductive): should these WF goals also be unproductive?. We could also just manually add each goal and use Misc for the WF goals 🤷
doesn't matter for coherence rn
r=me with either approach
Contributor
Author
There was a problem hiding this comment.
WellFormed is required to constrain bivariant parameters
yea, that's my understanding when turned this into a test.
I'll make it misc so we don't accidentally commit to this.
compiler-errors
force-pushed
the
new-solver-crashes-tweaks
branch
from
5eda058 to
484362e
Compare
Contributor
Author
|
@bors r=lcnr rollup |
Collaborator
bors
added
S-waiting-on-bors
TaKO8Ki
added a commit
to TaKO8Ki/rust
that referenced
this pull request
Mar 24, 2025
…-tweaks, r=lcnr Fix/tweak some tests in new solver Bunch of miscellaneous new solver tweaks that I found from the failing tests. Can split these out, but they all seemed small enough to not warrant separate PRs. r? lcnr
TaKO8Ki
added a commit
to TaKO8Ki/rust
that referenced
this pull request
Mar 24, 2025
…-tweaks, r=lcnr Fix/tweak some tests in new solver Bunch of miscellaneous new solver tweaks that I found from the failing tests. Can split these out, but they all seemed small enough to not warrant separate PRs. r? lcnr
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 25, 2025
Rollup of 10 pull requests Successful merges: - rust-lang#138385 (Keyword tweaks) - rust-lang#138580 (resolve: Avoid some unstable iteration 2) - rust-lang#138652 (Reintroduce remote-test support in run-make tests) - rust-lang#138701 (Make default_codegen_backend serializable) - rust-lang#138755 ([rustdoc] Remove duplicated loop when computing doc cfgs) - rust-lang#138829 (Slightly reword triagebot ping message for `relnotes-interest-group`) - rust-lang#138837 (resolve: Avoid remaining unstable iteration) - rust-lang#138838 (Fix/tweak some tests in new solver) - rust-lang#138877 (Ignore doctests only in specified targets) - rust-lang#138895 (Add a helper for building an owner id in ast lowering) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 25, 2025
Rollup of 10 pull requests Successful merges: - rust-lang#138385 (Keyword tweaks) - rust-lang#138580 (resolve: Avoid some unstable iteration 2) - rust-lang#138652 (Reintroduce remote-test support in run-make tests) - rust-lang#138701 (Make default_codegen_backend serializable) - rust-lang#138755 ([rustdoc] Remove duplicated loop when computing doc cfgs) - rust-lang#138829 (Slightly reword triagebot ping message for `relnotes-interest-group`) - rust-lang#138837 (resolve: Avoid remaining unstable iteration) - rust-lang#138838 (Fix/tweak some tests in new solver) - rust-lang#138877 (Ignore doctests only in specified targets) - rust-lang#138895 (Add a helper for building an owner id in ast lowering) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 25, 2025
Rollup of 9 pull requests Successful merges: - rust-lang#138385 (Keyword tweaks) - rust-lang#138580 (resolve: Avoid some unstable iteration 2) - rust-lang#138652 (Reintroduce remote-test support in run-make tests) - rust-lang#138701 (Make default_codegen_backend serializable) - rust-lang#138755 ([rustdoc] Remove duplicated loop when computing doc cfgs) - rust-lang#138829 (Slightly reword triagebot ping message for `relnotes-interest-group`) - rust-lang#138837 (resolve: Avoid remaining unstable iteration) - rust-lang#138838 (Fix/tweak some tests in new solver) - rust-lang#138895 (Add a helper for building an owner id in ast lowering) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 25, 2025
Rollup of 9 pull requests Successful merges: - rust-lang#138385 (Keyword tweaks) - rust-lang#138580 (resolve: Avoid some unstable iteration 2) - rust-lang#138652 (Reintroduce remote-test support in run-make tests) - rust-lang#138701 (Make default_codegen_backend serializable) - rust-lang#138755 ([rustdoc] Remove duplicated loop when computing doc cfgs) - rust-lang#138829 (Slightly reword triagebot ping message for `relnotes-interest-group`) - rust-lang#138837 (resolve: Avoid remaining unstable iteration) - rust-lang#138838 (Fix/tweak some tests in new solver) - rust-lang#138895 (Add a helper for building an owner id in ast lowering) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 25, 2025
Rollup merge of rust-lang#138838 - compiler-errors:new-solver-crashes-tweaks, r=lcnr Fix/tweak some tests in new solver Bunch of miscellaneous new solver tweaks that I found from the failing tests. Can split these out, but they all seemed small enough to not warrant separate PRs. r? lcnr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bunch of miscellaneous new solver tweaks that I found from the failing tests. Can split these out, but they all seemed small enough to not warrant separate PRs.
r? lcnr