Add bootstrap step diff to CI job analysis#138930
Merged
bors merged 2 commits intorust-lang:masterfrom Mar 26, 2025
Merged
Conversation
Collaborator
|
Failed to set assignee to
|
rustbot
added
A-testsuite
Merged
Member
Author
|
r? @marcoieni |
marcoieni
reviewed
Mar 25, 2025
Kobzol
force-pushed
the
analyze-bootstrap-diffs
branch
from
5855a56 to
b32e90b
Compare
marcoieni
reviewed
Mar 25, 2025
Member
marcoieni
left a comment
marcoieni
left a comment
There was a problem hiding this comment.
small nit. otherwise looks good. feel free to r=me 👍
Kobzol
force-pushed
the
analyze-bootstrap-diffs
branch
from
b32e90b to
813783e
Compare
Member
Author
|
@bors r=marcoieni |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 26, 2025
Rollup of 7 pull requests Successful merges: - rust-lang#138483 (Target modifiers fix for bool flags without value) - rust-lang#138818 (Don't produce debug information for compiler-introduced-vars when desugaring assignments.) - rust-lang#138898 (Mostly parser: Eliminate code that's been dead / semi-dead since the removal of type ascription syntax) - rust-lang#138930 (Add bootstrap step diff to CI job analysis) - rust-lang#138954 (Ensure `define_opaque` attrs are accounted for in HIR hash) - rust-lang#138959 (Revert "Make MatchPairTree::place non-optional") - rust-lang#138967 (Fix typo in error message) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 26, 2025
Rollup merge of rust-lang#138930 - Kobzol:analyze-bootstrap-diffs, r=marcoieni Add bootstrap step diff to CI job analysis This PR adds another analysis to the job analysis report in GitHub summary. It compares (diffs) bootstrap steps executed by the parent run and by the current commit. This will help us figure out if the bootstrap invocation did something different than before, and also how did the duration of individual steps and bootstrap invocations change. Can be tested on the rust-lang#119899 PR like this: ```bash $ curl https://ci-artifacts.rust-lang.org/rustc-builds/3d3394eb64ee2f99ad1a2b849b376220fd38263e/metrics-mingw-check.json > metrics.json $ cargo run --manifest-path src/ci/citool/Cargo.toml postprocess-metrics metrics.json --job-name mingw-check --parent 961351c > out.md ``` r? `@marcoie`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds another analysis to the job analysis report in GitHub summary. It compares (diffs) bootstrap steps executed by the parent run and by the current commit. This will help us figure out if the bootstrap invocation did something different than before, and also how did the duration of individual steps and bootstrap invocations change.
Can be tested on the #119899 PR like this:
r? @marcoie