feat(config): Add ChangeId enum for suppressing warnings by Shourya742 · Pull Request #138986 · rust-lang/rust

Shourya742 · 2025-03-26T12:52:06Z

rustbot · 2025-03-26T12:52:10Z

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-03-26T12:52:12Z

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

Shourya742 · 2025-03-26T13:05:20Z

Interesting stuff—TOML only supports i64. Would it make sense to change change_id from usize to isize? An alternative approach could be using a negative change_id to indicate the suppression of console warnings. The downside is that if we switch to isize, 32-bit architecture machines will have their range reduced to i32. However, on those machines, TOML's i64 range can still easily cover u32 values.

jieyouxu · 2025-03-26T15:59:20Z

My serde is rusty (hah), but I think there's something like an {deserialize,serialize}_with attr that takes a simple fn instead of a full blown deserializer

Shourya742 · 2025-03-27T04:06:31Z

My serde is rusty (hah), but I think there's something like an {deserialize,serialize}_with attr that takes a simple fn instead of a full blown deserializer

I believe deserialize_with and serialize_with can only be applied to struct or enum fields, not directly to types themselves. That said, if we're only ever deserializing ChangeId through ChangeIdWrapper, then this approach could work. I was just assuming that ChangeId might also need to be deserialized independently, in which case implementing Deserialize directly for it made more sense.

src/bootstrap/src/core/config/config.rs

src/bootstrap/src/bin/main.rs

src/bootstrap/src/utils/change_tracker.rs

src/bootstrap/src/bin/main.rs

Introduces the `ChangeId` enum to allow suppressing `change_id` warnings. Now, `ChangeId` supports both numeric values and the string literal `"ignore"`. Numeric values behave as expected, while `"ignore"` is used to suppress warning messages.

Shourya742 · 2025-03-27T16:35:24Z

Hello @Kobzol , all suggestions have been addressed.

Kobzol

Tried this locally, seems to work well. The code is also nicer, thanks! Left a few remaining nits.

Also, to make this new option a bit more discovereable, could you please modify the "to silence this warning" message, to mention this new option? Something like NOTE: to silence this warning, update bootstrap.tomlto usechange-id = 138986orchange-id = "ignore" instead. Thanks!

src/bootstrap/src/core/config/config.rs

src/bootstrap/src/utils/change_tracker.rs

rustbot · 2025-03-27T17:41:48Z

This PR modifies bootstrap.example.toml.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

Shourya742 · 2025-03-27T17:46:55Z

Hello @Kobzol, I've updated the descriptions. Thanks a lot for the review

Kobzol

Thank you! After fixing the missing space, you can write @bors r=kobzol to approve this PR.

@bors delegate+

src/bootstrap/src/bin/main.rs

…nge-id description references

Shourya742 · 2025-03-28T04:24:49Z

@bors r=kobzol

bors · 2025-03-28T04:24:51Z

@Shourya742: 🔑 Insufficient privileges: Not in reviewers

Kobzol · 2025-03-28T07:53:21Z

Looks like bors missed my command, sorry. Thank you for the PR!

@bors r+ rollup

bors · 2025-03-28T07:53:24Z

📌 Commit b24083b has been approved by Kobzol

It is now in the queue for this repository.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#137889 (update outdated doc with new example) - rust-lang#138104 (Greatly simplify doctest parsing and information extraction) - rust-lang#138678 (rustc_resolve: fix instability in lib.rmeta contents) - rust-lang#138986 (feat(config): Add ChangeId enum for suppressing warnings) - rust-lang#139038 (Update target maintainers for thumb targets to reflect new REWG Arm team name) - rust-lang#139045 (bootstrap: update `test_find` test) - rust-lang#139047 (Remove ScopeDepth) Failed merges: - rust-lang#139044 (bootstrap: Avoid cloning `change-id` list) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#138986 - Shourya742:2025-03-25-add-ignore-to-change-id, r=Kobzol feat(config): Add ChangeId enum for suppressing warnings closes: rust-lang#138925

rustbot assigned Kobzol Mar 26, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 26, 2025

This comment has been minimized.

Sign in to view

Shourya742 force-pushed the 2025-03-25-add-ignore-to-change-id branch from 3d54f33 to d58b5d5 Compare March 26, 2025 13:56

Kobzol reviewed Mar 27, 2025

View reviewed changes

src/bootstrap/src/core/config/config.rs Outdated Show resolved Hide resolved

src/bootstrap/src/bin/main.rs Outdated Show resolved Hide resolved

Shourya742 commented Mar 27, 2025

View reviewed changes

src/bootstrap/src/bin/main.rs Outdated Show resolved Hide resolved

Kobzol reviewed Mar 27, 2025

View reviewed changes

src/bootstrap/src/utils/change_tracker.rs Outdated Show resolved Hide resolved

src/bootstrap/src/bin/main.rs Outdated Show resolved Hide resolved

Shourya742 force-pushed the 2025-03-25-add-ignore-to-change-id branch 3 times, most recently from 3cbe872 to 2579dd1 Compare March 27, 2025 16:17

Shourya742 added 2 commits March 27, 2025 22:02

add changeInfo to change tracker

0244432

Shourya742 force-pushed the 2025-03-25-add-ignore-to-change-id branch from 2579dd1 to 0244432 Compare March 27, 2025 16:33

Kobzol reviewed Mar 27, 2025

View reviewed changes

src/bootstrap/src/core/config/config.rs Outdated Show resolved Hide resolved

src/bootstrap/src/utils/change_tracker.rs Outdated Show resolved Hide resolved

Kobzol approved these changes Mar 27, 2025

View reviewed changes

src/bootstrap/src/bin/main.rs Outdated Show resolved Hide resolved

Add new change-id option in bootstrap.example.toml and update the cha…

b24083b

…nge-id description references

Shourya742 force-pushed the 2025-03-25-add-ignore-to-change-id branch from 7a55d91 to b24083b Compare March 28, 2025 03:10

thaliaarchi mentioned this pull request Mar 28, 2025

bootstrap: Avoid cloning change-id list #139044

Merged

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2025

matthiaskrgr mentioned this pull request Mar 28, 2025

Rollup of 7 pull requests #139054

Merged

bors merged commit 60833b1 into rust-lang:master Mar 28, 2025
6 checks passed

rustbot added this to the 1.87.0 milestone Mar 28, 2025

Shourya742 deleted the 2025-03-25-add-ignore-to-change-id branch March 29, 2025 00:37

Uh oh!

Conversation

Shourya742 commented Mar 26, 2025

Uh oh!

rustbot commented Mar 26, 2025

Uh oh!

rustbot commented Mar 26, 2025

Uh oh!

Shourya742 commented Mar 26, 2025

Uh oh!

This comment has been minimized.

jieyouxu commented Mar 26, 2025

Uh oh!

Shourya742 commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Shourya742 commented Mar 27, 2025

Uh oh!

Kobzol left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rustbot commented Mar 27, 2025

Uh oh!

Shourya742 commented Mar 27, 2025

Uh oh!

Kobzol left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Shourya742 commented Mar 28, 2025

Uh oh!

bors commented Mar 28, 2025

Uh oh!

Kobzol commented Mar 28, 2025

Uh oh!

bors commented Mar 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Shourya742 commented Mar 27, 2025 •

edited

Loading

Kobzol left a comment •

edited

Loading