use uX::from instead of _ as uX in non - const contexts by bend-n · Pull Request #140435 · rust-lang/rust

bend-n · 2025-04-29T06:54:33Z

changes transmute(bool) -> integer to integer::from as opposed to bool as integer.
#136083 (comment)

@rustbot label L-unnecessary_transmutes

rustbot · 2025-04-29T06:54:38Z

rustbot has assigned @estebank.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-04-29T06:54:41Z

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

compiler-errors · 2025-04-29T14:30:37Z

compiler/rustc_mir_transform/src/check_unnecessary_transmutes.rs

+                func,
+                snippet,
+                span,
+                self.tcx.is_const_fn(def_id)


I don't believe this heuristic is complete. This leaves out const items and statics, for example.

could you add some tests for statics, consts, and in const blocks?

im not sure the heuristic is complete, but i added those tests and changed it a little.

compiler/rustc_mir_transform/src/check_unnecessary_transmutes.rs

compiler-errors

Just some nits, then I can approve.

compiler-errors · 2025-05-21T17:34:53Z

compiler/rustc_mir_transform/src/check_unnecessary_transmutes.rs

+                func,
+                snippet,
+                span,
+                self.tcx.is_const_fn(def_id)


Can you use tcx.hir_body_const_context(def_id.expect_local()).is_some()? That's actually probably the most correct way to do it.

compiler/rustc_mir_transform/src/check_unnecessary_transmutes.rs

bend-n · 2025-05-22T02:57:46Z

@rustbot ready

compiler-errors · 2025-05-22T07:33:31Z

@bors r+ rollup

bors · 2025-05-22T07:33:34Z

📌 Commit c0b365d has been approved by compiler-errors

It is now in the queue for this repository.

bors · 2025-05-22T09:30:52Z

☔ The latest upstream changes (presumably #141379) made this pull request unmergeable. Please resolve the merge conflicts.

bend-n · 2025-05-22T10:10:00Z

@bors r=@compiler-errors

bors · 2025-05-22T10:10:02Z

@bend-n: 🔑 Insufficient privileges: Not in reviewers

compiler-errors · 2025-05-22T10:10:46Z

@bors r+

bors · 2025-05-22T10:10:49Z

📌 Commit 8373bb1 has been approved by compiler-errors

It is now in the queue for this repository.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#135562 (Add ignore value suggestion in closure body) - rust-lang#139635 (Finalize repeat expr inference behaviour with inferred repeat counts) - rust-lang#139668 (Handle regions equivalent to 'static in non_local_bounds) - rust-lang#140218 (HIR ty lowering: Clean up & refactor the lowering of type-relative paths) - rust-lang#140435 (use uX::from instead of _ as uX in non - const contexts) - rust-lang#141130 (rustc_on_unimplemented cleanups) - rust-lang#141286 (Querify `coroutine_hidden_types`) Failed merges: - rust-lang#140247 (Don't build `ParamEnv` and do trait solving in `ItemCtxt`s when lowering IATs) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#140435 - bend-n:use_ux_from_instead_of_bool_as_ux_unnecessary_transmutes, r=compiler-errors use uX::from instead of _ as uX in non - const contexts changes `transmute(bool) -> integer` to `integer::from` as opposed to `bool as integer`. rust-lang#136083 (comment) `@rustbot` label L-unnecessary_transmutes

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#135562 (Add ignore value suggestion in closure body) - rust-lang#139635 (Finalize repeat expr inference behaviour with inferred repeat counts) - rust-lang#139668 (Handle regions equivalent to 'static in non_local_bounds) - rust-lang#140218 (HIR ty lowering: Clean up & refactor the lowering of type-relative paths) - rust-lang#140435 (use uX::from instead of _ as uX in non - const contexts) - rust-lang#141130 (rustc_on_unimplemented cleanups) - rust-lang#141286 (Querify `coroutine_hidden_types`) Failed merges: - rust-lang#140247 (Don't build `ParamEnv` and do trait solving in `ItemCtxt`s when lowering IATs) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned estebank Apr 29, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 29, 2025

rustbot added the L-unnecessary_transmutes Lint: unnecessary_transmutes label Apr 29, 2025

compiler-errors suggested changes Apr 29, 2025

View reviewed changes

compiler-errors assigned compiler-errors and unassigned estebank Apr 29, 2025

bend-n force-pushed the use_ux_from_instead_of_bool_as_ux_unnecessary_transmutes branch 3 times, most recently from 5f5d1c6 to 17737d6 Compare April 30, 2025 07:18

bend-n requested a review from compiler-errors May 4, 2025 19:05

compiler-errors suggested changes May 21, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 21, 2025

bend-n force-pushed the use_ux_from_instead_of_bool_as_ux_unnecessary_transmutes branch from 17737d6 to a57f326 Compare May 22, 2025 02:50

This comment has been minimized.

Sign in to view

bend-n force-pushed the use_ux_from_instead_of_bool_as_ux_unnecessary_transmutes branch from a57f326 to c0b365d Compare May 22, 2025 02:54

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 22, 2025

compiler-errors approved these changes May 22, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 22, 2025

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 22, 2025

use uX::from instead of _ as uX in non - const contexts

8373bb1

bend-n force-pushed the use_ux_from_instead_of_bool_as_ux_unnecessary_transmutes branch from c0b365d to 8373bb1 Compare May 22, 2025 10:08

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 22, 2025

matthiaskrgr mentioned this pull request May 22, 2025

Rollup of 7 pull requests #141396

Merged

bors merged commit bc6804d into rust-lang:master May 23, 2025
6 checks passed

rustbot added this to the 1.89.0 milestone May 23, 2025

bend-n deleted the use_ux_from_instead_of_bool_as_ux_unnecessary_transmutes branch May 23, 2025 05:04

Uh oh!

Conversation

bend-n commented Apr 29, 2025

Uh oh!

rustbot commented Apr 29, 2025

Uh oh!

rustbot commented Apr 29, 2025

Uh oh!

compiler-errors Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

compiler-errors Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

bend-n Apr 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

compiler-errors left a comment

Choose a reason for hiding this comment

Uh oh!

compiler-errors May 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

bend-n commented May 22, 2025

Uh oh!

compiler-errors commented May 22, 2025

Uh oh!

bors commented May 22, 2025

Uh oh!

bors commented May 22, 2025

Uh oh!

bend-n commented May 22, 2025

Uh oh!

bors commented May 22, 2025

Uh oh!

compiler-errors commented May 22, 2025

Uh oh!

bors commented May 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants