rust-analyzer subtree update#146086
Closed
lnicola wants to merge 182 commits into
Closed
Conversation
…ide a macro Descend into macros first.
Example
===
```rust
let x = $0;
```
Old completions:
```rust
let x = if $1 {
$0
};
```
This PR current completions:
```rust
let x = if $1 {
$2
} else {
$0
};
```
…-macro fix: Correctly goto `From` impl when on `into()` even when the call is inside a macro
…perms chore: fix crates/ide/src/folding_ranges.rs file perms
…en when some cannot rename
This caused rename to remove both, because it couldn't rename the derive-expanded one. I spent some time trying to create a test for this, before giving up. But I checked manually that this works.
Slim down compile time artifact progress reports
remove `add_attr()` from edit_in_place.rs because it use `ted`.
…lace_named_generic_with_impl remove `ted` from replace_named_generic_with_impl.rs
…_import Migrate `expand_glob_import` assist to use `SyntaxEditor`
Add assignment type analysis for ide-completion
fix external docs for exported macros
fix: Do not remove the original token when descending into derives
Remove only contain literals dbg statement
```rust
fn foo() {
let n = 2;
$0dbg!(3);
dbg!(2.6);
dbg!(1, 2.5);
dbg!('x');
dbg!(&n);
dbg!(n);
// needless comment
dbg!("foo");$0
}
```
->
```rust
fn foo() {
// needless comment
}
```
Old:
```rust
fn foo() {
3;
2.6;
(1, 2.5);
'x';
&n;
n;
// needless comment
"foo";
}
```
…e-dbg Add remove literal dbg stmt for remove_dbg
…lxvvyy Report the incorrect payload when failing to deserialize lsp messages
…wpkmxw Fix non-lsp compliant `Response` definition
Bumps [tmp](https://github.com/raszi/node-tmp) from 0.2.3 to 0.2.4. - [Changelog](https://github.com/raszi/node-tmp/blob/master/CHANGELOG.md) - [Commits](raszi/node-tmp@v0.2.3...v0.2.4) --- updated-dependencies: - dependency-name: tmp dependency-version: 0.2.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…ast_instead_of_str In handlers/extract_module.rs, generate ast::Module instead of String
feat: Add an option to remove reborrows from adjustment inlay hints
…m-indent Fix indent for move_guard_to_arm_body
…colon Fix ExprStmt delete semicolon for toggle_macro_delimiter
…zokqwu Enable warning logs by default
Replace it with normal `SolverDefId::TypeAliasId`. The split caused a very funny bug where code was getting `TypeAliasId` where it expected `ForeignId`, because `TypeAliasId` had a `From` impl from `hir_def::TypeAliasId` and `ForeignId` had not, plus a careless `into()`. I could've fixed this specific bug but opted to remove the split instead; currently, it just provides more room for bugs, as we don't have typed IDs for the solver anyway, and even when we'll have (hopefully), that doesn't seem like a very useful distinction, for example in hir-def foreign types are just `TypeAliasId` with some flags. Constructing a test for this isn't trivial; the trivial test (creating a foreign type, even proving a trait bound for it) fails to fail before the change, probably because we don't use the new solver everywhere yet so we don't trigger this specific code path.
fix: Remove `SolverDefId::ForeignId`
… operations of other unsafe blocks
…lver perf: Cache trait solving across queries in the same revision
…ated-unsafe-scope fix: In highlight_related, when on an unsafe block, don't highlight unsafe operations of other unsafe blocks
…attach fix: Attach the db in one more place in highlighting
Namely, mir lowering, const eval and IDE things.
A DB is enough.
minor: Don't require a full `InferenceTable` for `CastTy`
…0) to auto traits' substitutions Chalk represents dyn types as a list of predicate, the self type should be there. The next solver represents them quite differently. The `Self` was forgotten for the auto trait case.
…s-improve fix: Add progress bars to more places in analysis-stats
Bumps [tracing-subscriber](https://github.com/tokio-rs/tracing) from 0.3.19 to 0.3.20. - [Release notes](https://github.com/tokio-rs/tracing/releases) - [Commits](tokio-rs/tracing@tracing-subscriber-0.3.19...tracing-subscriber-0.3.20) --- updated-dependencies: - dependency-name: tracing-subscriber dependency-version: 0.3.20 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…acing-subscriber-0.3.20 Bump tracing-subscriber from 0.3.19 to 0.3.20
…-dyn-auto-trait fix: When mapping next-solver's `dyn` type, add `Self` (aka. bound var ^1.0) to auto traits' substitutions
…get-option fix: Avoid `--target` option being given twice to `rustc` when invoked through `cargo rustc` while fetching target data layout
Collaborator
|
rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
|
There are some changes on the solver crates from what r-a currently uses, I think it'll be easier to update r-a first to use the newest solver crates (are they published?) I can take care of that, if they are published. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subtree update of
rust-analyzerto rust-lang/rust-analyzer@21614ed.Created using https://github.com/rust-lang/josh-sync.
r? @ghost