bootstrap: Move the tests::snapshot submodule into its own file#146703
Closed
Zalathar wants to merge 1 commit into
Closed
bootstrap: Move the tests::snapshot submodule into its own file#146703Zalathar wants to merge 1 commit into
tests::snapshot submodule into its own file#146703Zalathar wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-review
Having these tests in an inline module made it harder to navigate both the snapshot tests and the surrounding module.
Member
Author
|
Forcibly regenerated all snapshots (via Now if I do |
Member
|
Hmm, I agree with the general idea, although I would rather just make all or most tests be snapshot tests, and then no longer call them "snapshot tests", but just "tests" :) So I'd just move them out of the inline module and just keep them in the file, and convert all the remaining tests to also use snapshots where it makes sense (#146595 is a step in that direction). |
Member
Author
|
This PR is unlikely to be merged in its current form, so I'll just close it for now. |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As more and more snapshot tests have been added or converted, this submodule has grown large enough that it no longer makes sense as an inline submodule. Pulling it out into its own file should make navigation easier.
r? Kobzol (or bootstrap)