Skip to content

rustdoc: Fix passes order so intra-doc links are collected after stripping passes #147809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 2 commits into from
Oct 18, 2025
Merged

rustdoc: Fix passes order so intra-doc links are collected after stripping passes #147809

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcc47d0
rustdoc: Fix passes order so intra-doc links are collected after stri…
GuillaumeGomez Oct 17, 2025
b3bb750
Add regression tests for intra-doc links
GuillaumeGomez Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
rustdoc: Fix passes order so intra-doc links are collected after stri… 
…pping passes
  • Loading branch information
@GuillaumeGomez
GuillaumeGomez committed Oct 17, 2025
commit fcc47d07a3bbe65450d212fadc044131fd292309
2 changes: 1 addition & 1 deletion src/librustdoc/passes/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,11 @@ pub(crate) const DEFAULT_PASSES: &[ConditionalPass] = &[
ConditionalPass::always(COLLECT_TRAIT_IMPLS),
ConditionalPass::always(CHECK_DOC_TEST_VISIBILITY),
ConditionalPass::always(CHECK_DOC_CFG),
ConditionalPass::always(COLLECT_INTRA_DOC_LINKS),
ConditionalPass::always(STRIP_ALIASED_NON_LOCAL),
ConditionalPass::new(STRIP_HIDDEN, WhenNotDocumentHidden),
ConditionalPass::new(STRIP_PRIVATE, WhenNotDocumentPrivate),
ConditionalPass::new(STRIP_PRIV_IMPORTS, WhenDocumentPrivate),
ConditionalPass::always(COLLECT_INTRA_DOC_LINKS),
ConditionalPass::always(PROPAGATE_DOC_CFG),
Copy link
Copy Markdown
Member

@fmease fmease Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, could you move the PROPAGATE_DOC_CFG pass somewhere above the STRIP_* ones to address #138907 (comment) and revert the change to tests/rustdoc-ui/invalid-cfg.rs you made in #138907 (i.e., make it private again and add an explanation) or do you want to do it in another PR?

My open PR #146529 is kinda blocked cuz I wanted to wait for all of these fixes ^^'

Copy link
Copy Markdown
Member

@fmease fmease Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed elsewhere, it's gonna be done in a separate PR

ConditionalPass::always(PROPAGATE_STABILITY),
ConditionalPass::always(RUN_LINTS),
Expand Down