Skip to content

std: sys: process: uefi: Add program searching#151014

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Ayush1325:uefi-cmd-path
Apr 27, 2026
Merged

std: sys: process: uefi: Add program searching#151014
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Ayush1325:uefi-cmd-path

Conversation

@Ayush1325
Copy link
Copy Markdown
Contributor

@Ayush1325 Ayush1325 commented Jan 12, 2026

  • Follow UEFI Shell search flow to search for programs while launching.
  • Tested using OVMF on QEMU.

@rustbot label +O-UEFI

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 12, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jan 12, 2026

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the O-UEFI UEFI label Jan 12, 2026
@Ayush1325 Ayush1325 mentioned this pull request Jan 12, 2026
Open
@Ayush1325
Copy link
Copy Markdown
Contributor Author

Ayush1325 commented Jan 24, 2026

cc @nicholasbishop

@Ayush1325
Copy link
Copy Markdown
Contributor Author

Ayush1325 commented Jan 25, 2026

Marking this as draft for now. Will update once split_paths is implemented (just found out about it).

@Ayush1325 Ayush1325 marked this pull request as draft January 25, 2026 10:11
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 25, 2026
@Ayush1325 Ayush1325 marked this pull request as ready for review February 17, 2026 05:20
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 17, 2026
@rustbot

This comment has been minimized.

Sign in to view
@Ayush1325
std: sys: process: uefi: Add program searching
47bec22 
- Follow UEFI Shell search flow to search for programs while launching.
- Tested using OVMF on QEMU.

Signed-off-by: Ayush Singh <ayush@beagleboard.org>
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Feb 17, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Ayush1325
Copy link
Copy Markdown
Contributor Author

Ayush1325 commented Mar 1, 2026

cc @nicholasbishop

@Ayush1325 Ayush1325 mentioned this pull request Mar 1, 2026
Merged
jhpratt added a commit to jhpratt/rust that referenced this pull request Mar 9, 2026
@jhpratt
Rollup merge of rust-lang#153244 - Ayush1325:uefi-run-test, r=Mark-Si…
de06d96 
…mulacrum

tools: remote-test-server: Add UEFI run support

Tested with OVMF on QEMU with Linux as the host running remote-test-client. The instructions for running tests are provided below:

1. Use rust-lld linker: `bootstrap.toml`

```toml
[rust]
lld = true

[target.x86_64-unknown-uefi]
linker = "rust-lld"
```

2. Use a custom startup.nsh script to auto-launch remote-test-server. This is optional.

```shell
fs1:
run.efi --sequential --bind "10.0.2.15:12345" --batch
```

3. Launch remote-test-server in QEMU. I am using uefi-run script [0].

```shell
uefi-run build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-uefi/release/remote-test-server.efi  -n --startup startup.nsh --tcp-port 12345
```

4. Run tests:

```shell
RUST_TEST_THREADS=1 TEST_DEVICE_ADDR="localhost:12345" ./x.py test tests/ui/abi --target x86_64-unknown-uefi --stage 1
```

Requires: rust-lang#151014
@rustbot label +O-UEFI
cc @nicholasbishop

[0]: https://github.com/Ayush1325/dotfiles/blob/2d13056bf8ca1931a234b72967d9e857c4afbf1a/uefi/.local/bin/uefi-run
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 9, 2026
@JonathanBrouwer
Rollup merge of rust-lang#153244 - Ayush1325:uefi-run-test, r=Mark-Si…
8b12e0a 
…mulacrum

tools: remote-test-server: Add UEFI run support

Tested with OVMF on QEMU with Linux as the host running remote-test-client. The instructions for running tests are provided below:

1. Use rust-lld linker: `bootstrap.toml`

```toml
[rust]
lld = true

[target.x86_64-unknown-uefi]
linker = "rust-lld"
```

2. Use a custom startup.nsh script to auto-launch remote-test-server. This is optional.

```shell
fs1:
run.efi --sequential --bind "10.0.2.15:12345" --batch
```

3. Launch remote-test-server in QEMU. I am using uefi-run script [0].

```shell
uefi-run build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-uefi/release/remote-test-server.efi  -n --startup startup.nsh --tcp-port 12345
```

4. Run tests:

```shell
RUST_TEST_THREADS=1 TEST_DEVICE_ADDR="localhost:12345" ./x.py test tests/ui/abi --target x86_64-unknown-uefi --stage 1
```

Requires: rust-lang#151014
@rustbot label +O-UEFI
cc @nicholasbishop

[0]: https://github.com/Ayush1325/dotfiles/blob/2d13056bf8ca1931a234b72967d9e857c4afbf1a/uefi/.local/bin/uefi-run
rust-timer added a commit that referenced this pull request Mar 9, 2026
@rust-timer
Unrolled build for #153244
6ca9155 
Rollup merge of #153244 - Ayush1325:uefi-run-test, r=Mark-Simulacrum

tools: remote-test-server: Add UEFI run support

Tested with OVMF on QEMU with Linux as the host running remote-test-client. The instructions for running tests are provided below:

1. Use rust-lld linker: `bootstrap.toml`

```toml
[rust]
lld = true

[target.x86_64-unknown-uefi]
linker = "rust-lld"
```

2. Use a custom startup.nsh script to auto-launch remote-test-server. This is optional.

```shell
fs1:
run.efi --sequential --bind "10.0.2.15:12345" --batch
```

3. Launch remote-test-server in QEMU. I am using uefi-run script [0].

```shell
uefi-run build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-uefi/release/remote-test-server.efi  -n --startup startup.nsh --tcp-port 12345
```

4. Run tests:

```shell
RUST_TEST_THREADS=1 TEST_DEVICE_ADDR="localhost:12345" ./x.py test tests/ui/abi --target x86_64-unknown-uefi --stage 1
```

Requires: #151014
@rustbot label +O-UEFI
cc @nicholasbishop

[0]: https://github.com/Ayush1325/dotfiles/blob/2d13056bf8ca1931a234b72967d9e857c4afbf1a/uefi/.local/bin/uefi-run
@Ayush1325
Copy link
Copy Markdown
Contributor Author

Ayush1325 commented Apr 25, 2026

cc @jhpratt

@jhpratt
Copy link
Copy Markdown
Member

jhpratt commented Apr 25, 2026

On the assumption you're pinging me for a review, I rely on the target maintainers to verify correctness. I won't approve a PR touching a lower tier target without sign-off from a target maintainer.

@Ayush1325
Copy link
Copy Markdown
Contributor Author

Ayush1325 commented Apr 25, 2026

On the assumption you're pinging me for a review, I rely on the target maintainers to verify correctness. I won't approve a PR touching a lower tier target without sign-off from a target maintainer.

Well, I can ping the maintainers again, but this has been open for 4 months without any sort of review.

@dvdhrm @nicholasbishop

nicholasbishop
nicholasbishop approved these changes Apr 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@nicholasbishop nicholasbishop left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay, and thank you for pinging again -- I thought I'd already reviewed this. LGTM.

View changes since this review

@jhpratt
Copy link
Copy Markdown
Member

jhpratt commented Apr 26, 2026

@bors r=jhpratt,nicholasbishop rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 26, 2026

📌 Commit 47bec22 has been approved by jhpratt,nicholasbishop

It is now in the queue for this repository.

⚠️ The following reviewer(s) could not be found: nicholasbishop

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2026
@jhpratt jhpratt mentioned this pull request Apr 27, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Apr 27, 2026
@bors
Auto merge of #155851 - jhpratt:rollup-Jst4hhC, r=jhpratt
4933094 
Rollup of 12 pull requests

Successful merges:

 - #149624 (Fix requires_lto targets needing lto set in cargo)
 - #155317 (`std::io::Take`: Clarify & optimize `BorrowedBuf::set_init` usage.)
 - #155579 (Make Rcs and Arcs use pointer comparison for unsized types)
 - #155588 (Implement more traits for FRTs)
 - #155708 (Fix heap overflow in slice::join caused by misbehaving Borrow)
 - #155778 (Avoid Vec allocation in TyCtxt::mk_place_elem)
 - #151014 (std: sys: process: uefi: Add program searching)
 - #155682 (Add boxing suggestions for `impl Trait` return type mismatches)
 - #155770 (Avoid misleading closure return type note)
 - #155818 (Convert attribute `FinalizeFn` to fn pointer)
 - #155829 (rustc_attr_parsing: use a `try {}` in `or_malformed`)
 - #155835 (couple of `crate_name` cleanups)
@rust-bors rust-bors Bot merged commit e3a6fa5 into rust-lang:main Apr 27, 2026
11 checks passed
@rustbot rustbot added this to the 1.97.0 milestone Apr 27, 2026
rust-timer added a commit that referenced this pull request Apr 27, 2026
@rust-timer
Unrolled build for #151014
c1c5bef 
Rollup merge of #151014 - Ayush1325:uefi-cmd-path, r=jhpratt,nicholasbishop

std: sys: process: uefi: Add program searching

- Follow UEFI Shell search flow to search for programs while launching.
- Tested using OVMF on QEMU.

@rustbot label +O-UEFI
@Ayush1325 Ayush1325 deleted the uefi-cmd-path branch April 27, 2026 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nicholasbishop nicholasbishop nicholasbishop approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ibraheemdev ibraheemdev

Labels

O-UEFI UEFI S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Ayush1325 @rustbot @jhpratt @nicholasbishop @ibraheemdev