Merged
Conversation
src/doc/guide.md
Outdated
Contributor
There was a problem hiding this comment.
It doesn't ignore doc comments entirely...
Contributor
There was a problem hiding this comment.
(e.g. it can and will complain about
fn foo() {
let a = 0u;
/// descriptive comment
let b = 1u;
}because doc comments can only be attached to items.)
Contributor
Author
There was a problem hiding this comment.
That's fair. Do you think this is too detailed a point to put into an introduction?
Contributor
There was a problem hiding this comment.
"the compiler mostly ignores them"?
Contributor
Author
|
Added in the 'mostly. |
bors
added a commit
that referenced
this pull request
Jul 9, 2014
I'm leaving off `rustdoc` usage because it won't work unless this is a `pub fn`, and I want to talk about public/private in the context of modules. I'm also not mentioning `//!` because it is exclusively used to provide the overview of a module.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 21, 2023
feat: Implement extern crate completion Hi, this is a draft PR for rust-lang#13002. I have basic completion working as well as a filter for existing extern crate imports in the same file. This is based on the tests, I have not actually tried this in an editor. Before going further I think this is a good point to stop and get feedback on the structure and approach I have taken so far. Let me know what you think :) I will make sure to add more tests, rebase commits and align with the code style guidelines before submitting a final version. A few specific questions : 1. Is there a better way to check for matching suggestions? right now I just test if an extern crate name starts with the current user input. 2. Am I creating the `CompletionItem` correctly? I noticed that `use_.rs` invokes a builder where as I do not. 3. When checking for existing extern crate imports the current implementation only looks at the current source file, is that sufficient?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm leaving off
rustdocusage because it won't work unless this is apub fn, and I want to talk about public/private in the context of modules. I'm also not mentioning//!because it is exclusively used to provide the overview of a module.