Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add regression test for #153837
  • Loading branch information
GuillaumeGomez committed Mar 18, 2026
commit c3994642114d5e40367f9b4ee4bf921bb72aaea8
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
[workspace]

[package]
edition = "2024"
name = "tester"
version = "0.1.0"

[[example]]
doc-scrape-examples = true
name = "window"
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
#![allow(dead_code)]
use tester::Window;

macro_rules! info {
($s:literal, $x:expr) => {{
let _ = $x;
}};
}

struct WindowState {
window: Window,
}

impl WindowState {
fn takes_ref(&self) {
info!("{:?}", self.window.id());
}

fn takes_mut(&mut self) {
info!("{:?}", self.window.id());
}
}

fn main() {}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
//! This test ensures that the call locations are not duplicated when generating scraped examples.
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is sadly lacking: the only way to ensure it works is to check it didn't fail to generate docs with the feature... Would be better to look at the generated target/debug/deps/*.example file but that would involve to reparse it, including compiler crates, etc. And unless I missed something obvious, there is sadly no easy way to achieve that...

//! To ensure that, we check that this call doesn't fail.
//! Regression test for <https://github.com/rust-lang/rust/issues/153837>.

use run_make_support::{cargo, htmldocck};

fn main() {
cargo().args(["rustdoc", "-Zunstable-options", "-Zrustdoc-scrape-examples"]).run();
Comment thread
Urgau marked this conversation as resolved.

htmldocck().arg("target/doc").arg("src/lib.rs").run();
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
//@has tester/struct.Window.html
//@count - '//*[@class="docblock scraped-example-list"]//span[@class="highlight"]' 1
//@has - '//*[@class="docblock scraped-example-list"]//span[@class="highlight"]' 'id'
//@count - '//*[@class="docblock scraped-example-list"]//span[@class="highlight focus"]' 1
//@has - '//*[@class="docblock scraped-example-list"]//span[@class="highlight focus"]' 'id'

pub struct Window {}

impl Window {
pub fn id(&self) -> u64 {
todo!()
}
}
Loading