Skip to content

[beta] Revert #151380 in beta#154307

Merged
rust-bors[bot] merged 1 commit into
rust-lang:betafrom
ShoyuVanilla:beta-fix
Apr 1, 2026
Merged

[beta] Revert #151380 in beta#154307
rust-bors[bot] merged 1 commit into
rust-lang:betafrom
ShoyuVanilla:beta-fix

Conversation

@ShoyuVanilla

@ShoyuVanilla ShoyuVanilla commented Mar 24, 2026

Copy link
Copy Markdown
Member

@ShoyuVanilla
Revert "Auto merge of rust-lang#151380 - ShoyuVanilla:shallow-resolve…
63cd511 
…-to-root-var, r=lcnr"

This reverts commit 75b9d89, reversing
changes made to 7bee525.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 24, 2026
@rustbot

rustbot commented Mar 24, 2026

Copy link
Copy Markdown
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the main branch for this repo, but this one is against beta. Please double check that you specified the right target!
  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@ShoyuVanilla ShoyuVanilla changed the title Revert #151380 Revert #151380 in beta Mar 24, 2026
@jieyouxu jieyouxu added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 24, 2026
@jieyouxu jieyouxu changed the title Revert #151380 in beta [beta] Revert #151380 in beta Mar 24, 2026
@theemathas theemathas mentioned this pull request Mar 26, 2026
Closed
@rustbot

rustbot commented Mar 26, 2026

Copy link
Copy Markdown
Collaborator

beta backport approved as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels are handled by them.

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Mar 26, 2026
@theemathas theemathas mentioned this pull request Mar 29, 2026
Closed
jieyouxu
jieyouxu approved these changes Apr 1, 2026
View reviewed changes

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

View changes since this review

@jieyouxu

jieyouxu commented Apr 1, 2026

Copy link
Copy Markdown
Member

r+-ing since this is a clean revert and beta revert backport was already approved.
@bors r+ rollup=never

@rust-bors

rust-bors Bot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 63cd511 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 1, 2026
@jieyouxu jieyouxu self-assigned this Apr 1, 2026
@JonathanBrouwer

JonathanBrouwer commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

@bors p=6
Scheduling this before the next rollup

@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 1, 2026
@rust-bors

rust-bors Bot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: jieyouxu
Duration: 3h 33m 17s
Pushing 8ebd005 to beta...

@rust-bors rust-bors Bot merged commit 8ebd005 into rust-lang:beta Apr 1, 2026
12 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Apr 1, 2026
@ShoyuVanilla ShoyuVanilla deleted the beta-fix branch April 2, 2026 03:19
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ShoyuVanilla @rustbot @jieyouxu @JonathanBrouwer @cuviper