Skip to content

try resolve issue 154452#154499

Closed
ArtemIsmagilov wants to merge 1 commit intorust-lang:mainfrom
ArtemIsmagilov:resolve-issue-154452
Closed

try resolve issue 154452#154499
ArtemIsmagilov wants to merge 1 commit intorust-lang:mainfrom
ArtemIsmagilov:resolve-issue-154452

Conversation

@ArtemIsmagilov
Copy link
Copy Markdown
Contributor

@ArtemIsmagilov ArtemIsmagilov commented Mar 28, 2026 •
edited
Loading

resolve #154452

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 28, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 28, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 8 candidates

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@ArtemIsmagilov ArtemIsmagilov marked this pull request as draft March 28, 2026 12:39
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2026
@ArtemIsmagilov ArtemIsmagilov marked this pull request as ready for review March 29, 2026 11:16
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 29, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@ArtemIsmagilov
init task
24e6ccb 
add set

add tabs

add deque

add Rc

add weak

add unique_rc

add others

fix
@ArtemIsmagilov
Copy link
Copy Markdown
Contributor Author

ArtemIsmagilov commented Mar 29, 2026

@Mark-Simulacrum done)

@Mark-Simulacrum
Copy link
Copy Markdown
Member

Mark-Simulacrum commented Mar 29, 2026

This is already being worked on in #154461, I believe? I'm going to close this in favor of that ongoing work.

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

example for std::collections HashMap method new_in() uses new() instead of new_in()

4 participants

@ArtemIsmagilov @rustbot @rust-log-analyzer @Mark-Simulacrum