Make sure we run the full suite, even when more specific filters are given#154555
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Apr 5, 2026
Merged
Make sure we run the full suite, even when more specific filters are given#154555rust-bors[bot] merged 1 commit intorust-lang:mainfrom
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
A-testsuite
Collaborator
|
r? @clubby789 rustbot has assigned @clubby789. Use Why was this reviewer chosen?The reviewer was selected based on:
|
jdonszelmann
force-pushed
the
specific-filters
branch
from
2faba4e to
617efdb
Compare
This comment has been minimized.
This comment has been minimized.
jdonszelmann
force-pushed
the
specific-filters
branch
from
617efdb to
cce34ad
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
clubby789
reviewed
Mar 31, 2026
jdonszelmann
force-pushed
the
specific-filters
branch
from
cce34ad to
4d7881e
Compare
Contributor
Author
|
That's a good suggestion @clubby789 |
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
This comment has been minimized.
This comment has been minimized.
jdonszelmann
force-pushed
the
specific-filters
branch
from
4d7881e to
d5caaa1
Compare
Contributor
Author
|
@rustbot review |
rustbot
added
S-waiting-on-review
Member
|
@bors r=clubby789,jieyouxu rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-timer
added a commit
that referenced
this pull request
Apr 5, 2026
Rollup merge of #154555 - jdonszelmann:specific-filters, r=clubby789,jieyouxu Make sure we run the full suite, even when more specific filters are given Some test suite's filter code took this into account, while others didn't. Imagine this: ``` x test tests/ui/sometest.rs tests/ui ``` This would run only `tests/ui/sometest.rs` since we filtered out `tests/ui` since it matches the name of the test suite. The reason `x test tests/ui` on its own works, is that if compiletest gets no filter paths, only a suite, it runs the entire suite. What I've implemented here is that when you pass the suite path, we effectively ignore specific filters and just run the entire suite since that'll include the more specific paths too. This was the case for a few other suites as well, like rustdocjs, but others actually handle this correctly (like clippy, which my code does edit but for which the behavior doesn't change). Hope this makes sense!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some test suite's filter code took this into account, while others didn't.
Imagine this:
This would run only
tests/ui/sometest.rssince we filtered outtests/uisince it matches the name of the test suite.The reason
x test tests/uion its own works, is that if compiletest gets no filter paths, only a suite, it runs the entire suite.What I've implemented here is that when you pass the suite path, we effectively ignore specific filters and just run the entire suite since that'll include the more specific paths too. This was the case for a few other suites as well, like rustdocjs, but others actually handle this correctly (like clippy, which my code does edit but for which the behavior doesn't change).
Hope this makes sense!