Suggest similar targets on unrecognized --target#155119
Closed
iyernaveenr wants to merge 1 commit intorust-lang:mainfrom
Closed
Suggest similar targets on unrecognized --target#155119iyernaveenr wants to merge 1 commit intorust-lang:mainfrom
--target#155119iyernaveenr wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
These commits modify compiler targets. |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @TaKO8Ki rustbot has assigned @TaKO8Ki. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
When an unrecognized target is passed to `--target`, use
`edit_distance_with_substrings` to find the closest built-in target
and suggest it in the error message.
Before:
error: could not find specification for target "riscv64-unknown-linux-gnu"
After:
error: could not find specification for target "riscv64-unknown-linux-gnu".
Did you mean `riscv64gc-unknown-linux-gnu`?
This helps with common mistakes like typos, missing components
(e.g. `x86_64-linux-gnu` -> `x86_64-unknown-linux-gnu`), or
swapped characters. No suggestion is shown when the input is too
far from any known target.
Signed-off-by: Naveen Iyer <iyernaveenr@gmail.com>
iyernaveenr
force-pushed
the
naveen_r_iyer/target_suggestion_on_unrecognized
branch
from
0bd001e to
6823123
Compare
Member
|
Thank you for the contribution, but #155132 already resolved this issue, so I will close this pul request. |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an unrecognized target is passed to
--target, useedit_distance_with_substringsto find the closest built-in target and suggest it in the error message.Before:
error: could not find specification for target "riscv64-unknown-linux-gnu"
After:
error: could not find specification for target "riscv64-unknown-linux-gnu".
Did you mean
riscv64gc-unknown-linux-gnu?This helps with common mistakes like typos, missing components (e.g.
x86_64-linux-gnu->x86_64-unknown-linux-gnu), or swapped characters. No suggestion is shown when the input is too far from any known target.Fixes #155085