Skip to content

Change GPU-offload install llvm cmake options use ; instead of ,#155573

Closed
Annonnymmousss wants to merge 1 commit intorust-lang:mainfrom
Annonnymmousss:docs/llvm-install-options
Closed

Change GPU-offload install llvm cmake options use ; instead of ,#155573
Annonnymmousss wants to merge 1 commit intorust-lang:mainfrom
Annonnymmousss:docs/llvm-install-options

Conversation

@Annonnymmousss
Copy link
Copy Markdown

@Annonnymmousss Annonnymmousss commented Apr 20, 2026

closes #155466

Earlier GPU-offload install llvm cmake options use , instead ; in the instructions which causes error while following the installation. This PR changes it to the desired command.

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 20, 2026

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @tshepang

@rustbot rustbot added A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 20, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 20, 2026

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 72 candidates
  • Random selection from 18 candidates

@tshepang
Copy link
Copy Markdown
Member

this is already in #155524

@JohnTitor
Copy link
Copy Markdown
Member

Closing in favor of that. Thanks for the PR anyway!

@JohnTitor JohnTitor closed this Apr 21, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rustc-dev-guide Area: rustc-dev-guide

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GPU-offload install llvm cmake options use , instead of ;

4 participants