Skip to content

test cleanups for ui/derives and ui/deriving#155615

Merged
rust-bors[bot] merged 4 commits intorust-lang:mainfrom
cyrgani:clean-deriving
Apr 22, 2026
Merged

test cleanups for ui/derives and ui/deriving#155615
rust-bors[bot] merged 4 commits intorust-lang:mainfrom
cyrgani:clean-deriving

Conversation

@cyrgani
Copy link
Copy Markdown
Contributor

@cyrgani cyrgani commented Apr 21, 2026

The eventual goal is for ui/deriving to be merged into ui/derives entirely. This PR focuses on the issue-*.rs tests in deriving and a few other no-longer-useful tests.
r? @Kivooeo

@rustbot rustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 21, 2026
@Kivooeo
Copy link
Copy Markdown
Member

Kivooeo commented Apr 21, 2026

r=me with ci green

@bors delegate+

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 21, 2026

✌️ @cyrgani, you can now approve this pull request!

If @Kivooeo told you to "r=me" after making some further change, then please make that change and post @bors r=Kivooeo.

@cyrgani
Copy link
Copy Markdown
Contributor Author

cyrgani commented Apr 21, 2026

@bors r=Kivooeo

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 21, 2026

📌 Commit d54b62f has been approved by Kivooeo

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Apr 22, 2026
test cleanups for `ui/derives` and `ui/deriving`

The eventual goal is for `ui/deriving` to be merged into `ui/derives` entirely. This PR focuses on the `issue-*.rs` tests in `deriving` and a few other no-longer-useful tests.
r? @Kivooeo
rust-bors Bot pushed a commit that referenced this pull request Apr 22, 2026
Rollup of 7 pull requests

Successful merges:

 - #155589 (Forbid `check-pass`/`build-pass`/`run-pass` directives in incremental tests)
 - #155610 (Add missing `dyn` keyword to `trait_alias` page of the Unstable Book)
 - #155615 (test cleanups for `ui/derives` and `ui/deriving`)
 - #154874 (Fix ICE for inherited const conditions on const closures)
 - #155605 (std: Update support for `wasm32-wasip3`)
 - #155613 (c-variadic: tweak `std` docs)
 - #155619 (Remove a bunch of unnecessary explicit lifetimes from the ast validator)
@rust-bors rust-bors Bot merged commit ca4aaaf into rust-lang:main Apr 22, 2026
11 checks passed
@rustbot rustbot added this to the 1.97.0 milestone Apr 22, 2026
github-actions Bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Apr 22, 2026
Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#155589 (Forbid `check-pass`/`build-pass`/`run-pass` directives in incremental tests)
 - rust-lang/rust#155610 (Add missing `dyn` keyword to `trait_alias` page of the Unstable Book)
 - rust-lang/rust#155615 (test cleanups for `ui/derives` and `ui/deriving`)
 - rust-lang/rust#154874 (Fix ICE for inherited const conditions on const closures)
 - rust-lang/rust#155605 (std: Update support for `wasm32-wasip3`)
 - rust-lang/rust#155613 (c-variadic: tweak `std` docs)
 - rust-lang/rust#155619 (Remove a bunch of unnecessary explicit lifetimes from the ast validator)
@cyrgani cyrgani deleted the clean-deriving branch April 22, 2026 10:05
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 25, 2026
cleanup, restructure and merge `tests/ui/deriving` into `tests/ui/derives`

As a followup to rust-lang#155615, this PR deletes some outdated tests from these directories, splits up `ui/derives` into smaller directories to roughly group tests by the derive macros they use and moves over all tests from `ui/deriving` into `ui/derives`.
r? @Kivooeo
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 25, 2026
cleanup, restructure and merge `tests/ui/deriving` into `tests/ui/derives`

As a followup to rust-lang#155615, this PR deletes some outdated tests from these directories, splits up `ui/derives` into smaller directories to roughly group tests by the derive macros they use and moves over all tests from `ui/deriving` into `ui/derives`.
r? @Kivooeo
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 25, 2026
cleanup, restructure and merge `tests/ui/deriving` into `tests/ui/derives`

As a followup to rust-lang#155615, this PR deletes some outdated tests from these directories, splits up `ui/derives` into smaller directories to roughly group tests by the derive macros they use and moves over all tests from `ui/deriving` into `ui/derives`.
r? @Kivooeo
rust-timer added a commit that referenced this pull request Apr 26, 2026
Rollup merge of #155659 - cyrgani:deriving-2, r=Kivooeo

cleanup, restructure and merge `tests/ui/deriving` into `tests/ui/derives`

As a followup to #155615, this PR deletes some outdated tests from these directories, splits up `ui/derives` into smaller directories to roughly group tests by the derive macros they use and moves over all tests from `ui/deriving` into `ui/derives`.
r? @Kivooeo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tidy Area: The tidy tool S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants