Simplify Config::track_state.#155671
Conversation
This is a callback used to track otherwise untracked state. It was added in rust-lang#116731 for Clippy. (It was originally named `hash_untracked_state`, and examples in the rustc-dev-guide still use that name.) The `StableHasher` argument is unused, and probably has never been used. There is a FIXME comment pointing this out, which was added more than a year ago. This commit removes the `StableHasher` callback argument. This also removes the need for `Options::untracked_state_hash`.
|
The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
rustbot
added
A-rustc-dev-guide
|
|
cc @Alexendoo @blyxyas for some Clippy dev eyes on this. |
|
If the original intent was as part of moving Clippy lints to module passes, then yeah we can remove it. Moving Clippy lints to module passes would complicate lint filtering. |
|
@bors r+ |
rust-bors
Bot
added
S-waiting-on-bors
…state, r=bjorn3 Simplify `Config::track_state`. This is a callback used to track otherwise untracked state. It was added in rust-lang#116731 for Clippy. (It was originally named `hash_untracked_state`, and examples in the rustc-dev-guide still use that name.) The `StableHasher` argument is unused, and probably has never been used. There is a FIXME comment pointing this out, which was added more than a year ago. This commit removes the `StableHasher` callback argument. This also removes the need for `Options::untracked_state_hash`. r? @bjorn3
|
Thanks for the fast responses, everyone! |
…uwer Rollup of 7 pull requests Successful merges: - #155621 (Document #[diagnostic::on_move] in the unstable book.) - #155671 (Simplify `Config::track_state`.) - #153482 (tests/ui/macros: add annotations for reference rules) - #155075 (Add docs about SDKs and C compilation on armv7a-vex-v5) - #155685 (Fix `get_child_at_index` return type hints) - #155686 (Fix array template arg lookup behavior) - #155690 (Fix classify_union to return Union for regular unions)
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
added
merged-by-bors
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 36ba2c7 (parent) -> 9836b06 (this PR) Test differencesShow 2 test diffs2 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 9836b06b55f5389f605ee7766eeecd9f17a86cb5 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (9836b06): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (secondary 2.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -2.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 490.512s -> 493.683s (0.65%) |
6 participants
This is a callback used to track otherwise untracked state. It was added in #116731 for Clippy. (It was originally named
hash_untracked_state, and examples in the rustc-dev-guide still use that name.) TheStableHasherargument is unused, and probably has never been used. There is a FIXME comment pointing this out, which was added more than a year ago.This commit removes the
StableHashercallback argument. This also removes the need forOptions::untracked_state_hash.r? @bjorn3