Skip to content

Rollup of 3 pull requests#155901

Merged
rust-bors[bot] merged 6 commits intorust-lang:mainfrom
jhpratt:rollup-R3JaeoO
Apr 28, 2026
Merged

Rollup of 3 pull requests#155901
rust-bors[bot] merged 6 commits intorust-lang:mainfrom
jhpratt:rollup-R3JaeoO

Conversation

@jhpratt
Copy link
Copy Markdown
Member

@jhpratt jhpratt commented Apr 28, 2026

Successful merges:

r? @ghost

Create a similar rollup

@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Apr 28, 2026
@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 28, 2026
@jhpratt
Copy link
Copy Markdown
Member Author

jhpratt commented Apr 28, 2026

@bors r+ rollup=never p=5

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 28, 2026

📌 Commit 6960391 has been approved by jhpratt

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 28, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 28, 2026

☀️ Test successful - CI
Approved by: jhpratt
Duration: 3h 18m 59s
Pushing b806d39 to main...

@rust-bors rust-bors Bot merged commit b806d39 into rust-lang:main Apr 28, 2026
12 checks passed
@rustbot rustbot added this to the 1.97.0 milestone Apr 28, 2026
@rust-timer
Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#155894 triagebot: add myself to libs rotation 1da1d31ab82c289b85c2d3ebdbd02738d2d844cd (link)
#155897 Add regression test for LLVM bug with huge stack frames bc81c8b94a4e7a164165fdfbc06212d87c9ff7a1 (link)
#155900 Refer to FnDef as "function item", not "function pointer" a2019f83c48eddad405752e9eded40315b9d9def (link)

previous master: b20956b0f4

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Copy Markdown
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing b20956b (parent) -> b806d39 (this PR)

Test differences

Show 12 test diffs

Stage 1

  • [ui] tests/ui/codegen/huge-stacks.rs#optimized: [missing] -> pass (J1)
  • [ui] tests/ui/codegen/huge-stacks.rs#unoptimized: [missing] -> pass (J1)
  • [ui] tests/ui/codegen/huge-stacks.rs#optimized: [missing] -> ignore (ignored when the LLVM version 21.1.2 is older than 22.0.0) (J3)
  • [ui] tests/ui/codegen/huge-stacks.rs#unoptimized: [missing] -> ignore (ignored when the LLVM version 21.1.2 is older than 22.0.0) (J3)

Stage 2

  • [ui] tests/ui/codegen/huge-stacks.rs#optimized: [missing] -> ignore (only executed when the pointer width is 64bit) (J0)
  • [ui] tests/ui/codegen/huge-stacks.rs#unoptimized: [missing] -> ignore (only executed when the pointer width is 64bit) (J0)
  • [ui] tests/ui/codegen/huge-stacks.rs#optimized: [missing] -> pass (J2)
  • [ui] tests/ui/codegen/huge-stacks.rs#unoptimized: [missing] -> pass (J2)
  • [ui] tests/ui/codegen/huge-stacks.rs#optimized: [missing] -> ignore (ignored when the LLVM version 21.1.2 is older than 22.0.0) (J4)
  • [ui] tests/ui/codegen/huge-stacks.rs#unoptimized: [missing] -> ignore (ignored when the LLVM version 21.1.2 is older than 22.0.0) (J4)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard b806d39f033b05ea5aec9a353df75314007a728c --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-gnu-aux: 1h 51m -> 2h 20m (+26.2%)
  2. dist-ohos-x86_64: 1h 23m -> 1h 3m (-24.7%)
  3. dist-powerpc-linux: 1h 14m -> 1h 30m (+21.8%)
  4. x86_64-msvc-1: 2h 31m -> 2h 3m (-18.4%)
  5. pr-check-1: 34m 38s -> 28m 23s (-18.0%)
  6. test-various: 1h 39m -> 1h 55m (+16.1%)
  7. armhf-gnu: 1h 39m -> 1h 24m (-15.2%)
  8. x86_64-gnu-debug: 2h 4m -> 1h 47m (-13.8%)
  9. x86_64-gnu-tools: 1h 3m -> 55m 18s (-13.6%)
  10. x86_64-gnu-llvm-21-1: 1h 16m -> 1h 6m (-13.5%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (b806d39): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.2% [-0.2%, -0.2%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary -4.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.7% [-7.3%, -2.1%] 2
All ❌✅ (primary) - - 0

Cycles

This perf run didn't have relevant results for this metric.

Binary size

Results (primary -0.1%, secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.1% [-0.2%, -0.0%] 49
Improvements ✅
(secondary)
-0.1% [-0.2%, -0.0%] 23
All ❌✅ (primary) -0.1% [-0.2%, -0.0%] 49

Bootstrap: 489.569s -> 489.748s (0.04%)
Artifact size: 393.41 MiB -> 393.29 MiB (-0.03%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-meta Area: Issues & PRs about the rust-lang/rust repository itself merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants