Skip to content

lower edition requirements for some async-closure test helpers#157075

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
tshepang:lower-edition-requirement
Jun 15, 2026
Merged

lower edition requirements for some async-closure test helpers#157075
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
tshepang:lower-edition-requirement

Conversation

@tshepang

Copy link
Copy Markdown
Member

No description provided.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 28, 2026
@rustbot

rustbot commented May 28, 2026

Copy link
Copy Markdown
Collaborator

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 20 candidates

@tshepang tshepang changed the title lower edition requirements for some async-closure tests lower edition requirements for some async-closure test helpers May 28, 2026
@tshepang tshepang force-pushed the lower-edition-requirement branch from 22a73bf to 15c69e2 Compare May 28, 2026 16:52
@tshepang tshepang force-pushed the lower-edition-requirement branch from 15c69e2 to 5c95bf5 Compare May 28, 2026 16:53

@wesleywiser wesleywiser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine but I feel like I'm missing context for why we want to do this. Is there a related discussion somewhere?

View changes since this review

@wesleywiser wesleywiser added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2026
@tshepang

tshepang commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

it's just random dirt I found as I was looking at the tests (while doing some Ferrocene test coverage work)

@wesleywiser

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-bors Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 5c95bf5 has been approved by wesleywiser

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 15, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 15, 2026
…, r=wesleywiser

lower edition requirements for some async-closure test helpers
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 15, 2026
…, r=wesleywiser

lower edition requirements for some async-closure test helpers
rust-bors Bot pushed a commit that referenced this pull request Jun 15, 2026
Rollup of 13 pull requests

Successful merges:

 - #152544 (Stabilize `int_format_into` feature)
 - #157507 (fixed: differentiation between uninitialized and possibly uninitialized)
 - #155750 (Document that `ManuallyDrop`'s `Box` interaction has been fixed)
 - #157075 (lower edition requirements for some async-closure test helpers)
 - #157627 (remove LLVM `va_end` calls)
 - #157660 (normalize instead of evaluating type const patterns)
 - #157692 (Don't emit `unused_parens` suggestion for proc-macro-synthesized parens around bounds)
 - #157908 (fix binding const argument to assoc type suggestion)
 - #157915 (scalable vecs size incl. num vecs + no sret for scalable vecs)
 - #157916 (Avoid ICE on invalid crate-level cfg_attr predicates)
 - #157919 (mention in the `extern "tail"` error that it's supported on x86)
 - #157920 (mailmap: add mu001999)
 - #157924 (Update books)
@rust-bors rust-bors Bot merged commit 0c01345 into rust-lang:main Jun 15, 2026
12 checks passed
@rustbot rustbot added this to the 1.98.0 milestone Jun 16, 2026
rust-timer added a commit that referenced this pull request Jun 16, 2026
Rollup merge of #157075 - tshepang:lower-edition-requirement, r=wesleywiser

lower edition requirements for some async-closure test helpers
@tshepang tshepang deleted the lower-edition-requirement branch June 16, 2026 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants