tests: codegen-llvm: Expect the new mangling scheme in bpf-abi-indirect-return#157306
Open
vadorovsky wants to merge 6 commits into
Open
tests: codegen-llvm: Expect the new mangling scheme in bpf-abi-indirect-return#157306vadorovsky wants to merge 6 commits into
vadorovsky wants to merge 6 commits into
Conversation
rustbot
added
A-test-infra-minicore
…ct-return The new Rust symbol mangling[0] uses prefix `_R` instead of `@_ZN`. [0] https://rust-lang.github.io/rfcs/2603-rust-symbol-name-mangling-v0.html
`c_void` is an equivalent of a C type, where non-camel-case naming is more appropriate. The usage of `enum` is an implementation detail.
To make comparision possible in minicore, add support for the `eq` language feature and the `ParialEq` trait, along with implementation for all integer types.
To make indexing operations possible in minicore, add support for the `index` language feature and the `Index` trait, along with implementation for `[T; N]` and `[T]`.
Instead of keeping it as `only-bpf`, use minicore. This way we make sure it will never get outdated again.
vadorovsky
force-pushed
the
vad/llvm-codegen-bpf-abi-indirect-return
branch
from
e045560 to
2cd45a5
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new Rust symbol mangling uses prefix
_Rinstead of@_ZN.Instead of keeping the test as
only-bpf, use minicore. This way we make sure it will never get outdated again.Make necessary changes to minicore to support the test:
Addimplementation for integer types.eqlanguage feature andPartialEqtrait.indexlanguage feature andIndextrait.See individual commits for details.
r? @nagisa