disallow most attrs on eiis#157312
Open
jdonszelmann wants to merge 1 commit into
Open
Conversation
rustbot
added
S-waiting-on-review
JonathanBrouwer
requested changes
Jun 2, 2026
| } | ||
|
|
||
| #[derive(Diagnostic)] | ||
| #[diag("only a small subset of attributes are supported on externally implementable items")] |
Contributor
There was a problem hiding this comment.
Could we have a few tests for this? Both for attributes that are supported such as inline, and attributes that are not supported
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most attributes do not make sense on EIIs. Whether they're copied to the macro, default, or foreign item is also highly dependent per attribute.
I was thinking of ways to configure this, though I don't think we need that kind of complexity rn. For now I just reject them all, except for ones that obviously make sense or are necessary for current usage in std.
user attr macros are blanket-rejected with this too, which seems good, it seems cursed to present expanded eiis to them.
r? @JonathanBrouwer