Rewrite target checking for `#[sanitize]` by JonathanBrouwer · Pull Request #157332 · rust-lang/rust

JonathanBrouwer · 2026-06-02T20:31:37Z

rustbot · 2026-06-02T20:31:40Z

Some changes occurred in compiler/rustc_attr_parsing

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

JonathanBrouwer · 2026-06-02T20:32:46Z

+        Allow(Target::Impl { of_trait: true }),
+        Allow(Target::Mod),
+        Allow(Target::Crate),
+        Allow(Target::Static),


Note that attribute parsing has slightly better/different target information than check_attr.rs does

We allow Target::Crate here, which falls under Target::Mod in check_attr.rs

We allow Target::Method(MethodKind::TraitImpl) here, which falls under Target::Impl { of_trait: true } in check_attr.rs

View changes since the review

Okay, I raised some concerns on the tracking issue. #39699 (comment)

This pr won't change the behavior and sanitize is still unstable so I don't mind proceeding.

mejrs

Please add a macro call test here as well.

View changes since this review

mejrs · 2026-06-02T21:20:56Z

+LL | #[sanitize(address = "off")]
+   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
-   = help: sanitize attribute can be applied to a function (with body), impl block, or module


function (with body) would be nice to keep. Can we update allowed_targets_applied to do this?

I've added it as a group to allowed_targets_applied, but this currently means that this group will only be shown if the attribute is applied to a target that is a function without a body. I'll see if I can refactor the allowed_targets_applied to be better about this in a follow-up PR

mejrs · 2026-06-02T22:10:42Z

+        Allow(Target::Impl { of_trait: true }),
+        Allow(Target::Mod),
+        Allow(Target::Crate),
+        Allow(Target::Static),


Okay, I raised some concerns on the tracking issue. #39699 (comment)

This pr won't change the behavior and sanitize is still unstable so I don't mind proceeding.

mejrs · 2026-06-02T22:22:48Z

+#[derive(Diagnostic)]
+#[diag("`#[sanitize({$field} = ...)]` attribute cannot be used on statics")]
+#[help("`#[sanitize]` can be used on statics if only the address is sanitized")]
+pub(crate) struct SanitizeInvalidStatic {
+    #[primary_span]
+    pub span: Span,
+    pub field: &'static str,
+}


You can have multiple fields in this attribute, how does this error display in that case?

It currently only complains about the first one it finds, I was considering generating a diagnostic for every one but that feels like it would get spammy very quickly

rustbot · 2026-06-02T22:25:17Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

JonathanBrouwer · 2026-06-03T07:54:19Z

@rustbot ready

mejrs

@bors r+ rollup

View changes since this review

rust-bors · 2026-06-03T10:42:42Z

📌 Commit b0ccb01 has been approved by mejrs

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 5. This pull request will be tested once the tree is reopened.

@mejrs

…=mejrs Rewrite target checking for `#[sanitize]` r? @mejrs

…uwer Rollup of 15 pull requests Successful merges: - #155763 (Promotes 5 Thumb-mode bare-metal Arm targets to Tier 2) - #156953 (delegation: emit error when there is an infer lifetime in user-specified args) - #157248 (delegation: move statements out of the first arg) - #157263 (rustc_codegen_ssa: Refactor `ArchiveEntry` to include entry kind) - #157311 (Use weak linkage for EII defaults) - #156089 (Fix unused_parens for pinned reference patterns) - #156928 (Remove -Zemscripten-wasm-eh) - #157236 (Reorganize `tests/ui/issues` [3/N]) - #157287 (Const generics: remove AliasTerm::kind(), and small fixes) - #157294 (Split coroutine layout computation to its own file) - #157328 (windows: Elide division-by-zero checks in Instant::now()) - #157331 (Rewrite target checking for `#[link]`) - #157336 (Enable `clippy::mem_replace_with_default`) - #157362 (Fix trivial wf module argument/doc comment name mismatches) - #157364 (Rewrite target checking of `rustc_dummy`) Failed merges: - #157332 (Rewrite target checking for `#[sanitize]`)

rustbot · 2026-06-03T16:30:20Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

JonathanBrouwer · 2026-06-03T16:30:25Z

@bors r=mejrs

rust-bors · 2026-06-03T16:30:28Z

📌 Commit 97dc1b1 has been approved by mejrs

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 5. This pull request will be tested once the tree is reopened.

@mejrs

…=mejrs Rewrite target checking for `#[sanitize]` r? @mejrs

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 2, 2026

rustbot assigned mejrs Jun 2, 2026

JonathanBrouwer commented Jun 2, 2026

View reviewed changes

mejrs requested changes Jun 2, 2026

View reviewed changes

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 2, 2026

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 2, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 3, 2026

JonathanBrouwer force-pushed the target-sanitize branch from 2b59b34 to b0ccb01 Compare June 3, 2026 07:56

This comment has been minimized.

Sign in to view

mejrs approved these changes Jun 3, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 3, 2026

Rollup merge of rust-lang#157332 - JonathanBrouwer:target-sanitize, r…

608cba9

…=mejrs Rewrite target checking for `#[sanitize]` r? @mejrs

This was referenced Jun 3, 2026

Rollup of 15 pull requests #157375

Closed

Add more tests for the optimize attribute #157297

Open

Rollup of 15 pull requests #157376

Merged

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 3, 2026

This comment has been minimized.

Sign in to view

JonathanBrouwer added 3 commits June 3, 2026 18:27

Rewrite target checking for #[sanitize]

130b501

Add attr-on-mac-call test

f721e6c

Add "functions with a body" target group

97dc1b1

JonathanBrouwer force-pushed the target-sanitize branch from b0ccb01 to 97dc1b1 Compare June 3, 2026 16:30

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 3, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 3, 2026

Rollup merge of rust-lang#157332 - JonathanBrouwer:target-sanitize, r…

439671e

…=mejrs Rewrite target checking for `#[sanitize]` r? @mejrs

JonathanBrouwer mentioned this pull request Jun 3, 2026

Rollup of 8 pull requests #157387

Open

Uh oh!

Conversation

JonathanBrouwer commented Jun 2, 2026

Uh oh!

rustbot commented Jun 2, 2026

Uh oh!

JonathanBrouwer Jun 2, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mejrs Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

mejrs left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mejrs Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

JonathanBrouwer Jun 3, 2026

Choose a reason for hiding this comment

Uh oh!

mejrs Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

mejrs Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

JonathanBrouwer Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rustbot commented Jun 2, 2026

Uh oh!

JonathanBrouwer commented Jun 3, 2026

Uh oh!

This comment has been minimized.

mejrs left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Jun 3, 2026

Uh oh!

This comment has been minimized.

rustbot commented Jun 3, 2026

Uh oh!

JonathanBrouwer commented Jun 3, 2026

Uh oh!

rust-bors Bot commented Jun 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JonathanBrouwer Jun 2, 2026 •

edited by rustbot

Loading

mejrs left a comment •

edited by rustbot

Loading

JonathanBrouwer Jun 3, 2026 •

edited

Loading

mejrs left a comment •

edited by rustbot

Loading