Skip to content

tests: codegen-llvm: Ignore BPF targets in c-variadic-opt#157383

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
vadorovsky:vad/llvm-codegen-c-variadic-ignore-bpf
Jun 8, 2026
Merged

tests: codegen-llvm: Ignore BPF targets in c-variadic-opt#157383
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
vadorovsky:vad/llvm-codegen-c-variadic-ignore-bpf

Conversation

@vadorovsky

Copy link
Copy Markdown
Contributor

BPF does not support C variadics.

r? @nagisa

@rustbot

rustbot commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

compiletest directives have been modified. Please add or update docs for the
new or modified directive in src/doc/rustc-dev-guide/.

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 3, 2026
@rust-log-analyzer

This comment has been minimized.

@folkertdev folkertdev added the F-c_variadic `#![feature(c_variadic)]` label Jun 6, 2026
@folkertdev

Copy link
Copy Markdown
Contributor

The ci failure looks spurious, can you rebase and see if that fixes it?

@folkertdev

Copy link
Copy Markdown
Contributor

I'll just close and re-open to get CI to run

@folkertdev folkertdev closed this Jun 8, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 8, 2026
@folkertdev folkertdev reopened this Jun 8, 2026
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 8, 2026
@vadorovsky vadorovsky force-pushed the vad/llvm-codegen-c-variadic-ignore-bpf branch from b7b73d4 to 72cad5b Compare June 8, 2026 13:18
@rustbot

rustbot commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@folkertdev

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@rust-bors

rust-bors Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 72cad5b has been approved by folkertdev

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2026
rust-bors Bot pushed a commit that referenced this pull request Jun 8, 2026
…uwer

Rollup of 13 pull requests

Successful merges:

 - #147302 (asm! support for the Xtensa architecture)
 - #148820 (Add very basic "comptime" fn implementation)
 - #157299 (Fix unstable diagnostics in tests)
 - #143511 (Improve TLS codegen by marking the panic/init path as cold)
 - #154608 (Add `_value` API for number literals in proc-macro)
 - #156762 (xfs support in `test_rename_directory_to_non_empty_directory`)
 - #157300 (Relax test requirements for consistency)
 - #157383 (tests: codegen-llvm: Ignore BPF targets in c-variadic-opt)
 - #157413 (fix: don't suggest .into_iter() for .cloned()/.copied() on non-reference Option)
 - #157578 (Fix diagnostics for non-exhaustive destructuring assignments (#157553))
 - #157587 (explain that the size_of constant also serves to avoid optimizing away 'unused' size_of calls)
 - #157596 (test: remove ineffective link-extern-crate-with-drop-type test)
 - #157602 (rustdoc: Remove unnecessary fast path)
@rust-bors rust-bors Bot merged commit dcb272d into rust-lang:main Jun 8, 2026
12 checks passed
@rustbot rustbot added this to the 1.98.0 milestone Jun 8, 2026
rust-timer added a commit that referenced this pull request Jun 8, 2026
Rollup merge of #157383 - vadorovsky:vad/llvm-codegen-c-variadic-ignore-bpf, r=folkertdev

tests: codegen-llvm: Ignore BPF targets in c-variadic-opt

BPF does not support C variadics.

r? @nagisa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc F-c_variadic `#![feature(c_variadic)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants