Rename RandomSource -> Rng, DefaultRandomSource -> SystemRng#157539
Merged
Conversation
joshtriplett
added
the
T-libs-api
rustbot
added
the
S-waiting-on-author
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-author
Collaborator
|
r? @jhpratt rustbot has assigned @jhpratt. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
hanna-kruppe
reviewed
Jun 6, 2026
Member
|
Looks like a simple change; |
Member
|
I don't really want to bikeshed this all over again, but how about calling this |
Member
Author
|
@joboet |
Member
Author
I'm trying to figure out what the CI issue is. Currently re-running it because it's not clear to me if it's spurious or not. |
Per naming bikeshed in libs-api. `Rng` is shorter, and already established in the ecosystem. `System` makes it self-documenting that `SystemRng` gets its randomness from the system RNG.
joshtriplett
force-pushed
the
random-source-rename
branch
from
431abc5 to
0e51988
Compare
joshtriplett
changed the title
RandomSource -> Rng, DefaultRandomSource -> SysRngRandomSource -> Rng, DefaultRandomSource -> SystemRng
Member
Author
|
@bors r=jhpratt rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 17, 2026
Rollup of 7 pull requests Successful merges: - #157681 (Add instrument_fn attribute) - #149219 (Allow shortening lifetime in CoerceUnsized for &mut) - #157539 (Rename `RandomSource` -> `Rng`, `DefaultRandomSource` -> `SystemRng`) - #157980 (Some minor cleanups around hir ty/pat/expr) - #157988 (Fix incremental-finalize-fail proc macro test on AIX) - #157989 (run-make: handle AIX symbol cdylib export test) - #157998 (Add big disclaimer to the description of lint `explicit_outlives_requirements`)
rust-timer
added a commit
that referenced
this pull request
Jun 17, 2026
Rollup merge of #157539 - joshtriplett:random-source-rename, r=jhpratt Rename `RandomSource` -> `Rng`, `DefaultRandomSource` -> `SystemRng` Per naming bikeshed in libs-api. `Rng` is shorter, and already established in the ecosystem. `System` makes it self-documenting that `SystemRng` gets its randomness from the system RNG. This also makes it short and convenient to write `SystemRng.fill_bytes`, rather than `DefaultRandomSource.fill_bytes`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per naming bikeshed in libs-api.
Rngis shorter, and already established in the ecosystem.Systemmakes it self-documenting thatSystemRnggets its randomness from the system RNG.This also makes it short and convenient to write
SystemRng.fill_bytes, rather thanDefaultRandomSource.fill_bytes.