Eagerly fetch typeck results when linting

[Jarcho]

View all comments

The first commit avoids running the lint visitor if all lints were filtered out. In every other case the typeck results are accessed on every body making the delayed load pointless overhead.

[rustbot]

clippy is developed in its own repository. If possible, consider making this change to rust-lang/rust-clippy instead.

cc @rust-lang/clippy

[rustbot]

r? @Kivooeo

rustbot has assigned @Kivooeo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: compiler
• compiler expanded to 73 candidates
• Random selection from 20 candidates

[Jarcho]

Turns out that was load bearing for rustdoc. That's now been worked around and documented properly.

[fmease]

@bors try parent=4fc35880d9636c5a2679d18b034038123b09b294 @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: 0b2216b (0b2216bdab7b8a5d0d896736af184122a08d45de)
Base parent: 4fc3588 (4fc35880d9636c5a2679d18b034038123b09b294)

[rust-timer]

Error occured while categorizing benchmark run:

could not find start commit for bound Commit("4fc35880d9636c5a2679d18b034038123b09b294")

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[fmease]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: 1444460 (14444609e8e293e12bab60ce6cd32f4b81c9adcf)
Base parent: 9639eef (9639eefc07db282b25e9c83cdfebb10688ed5114)

[rust-timer]

Finished benchmarking commit (1444460): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

Results (secondary -0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.6%	[5.6%, 5.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.2%	[-3.9%, -2.6%]	2
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 482.613s -> 481.078s (-0.32%)
Artifact size: 390.75 MiB -> 391.18 MiB (0.11%)