rustdoc-json-types: Replace bincode dev-dependency with postcard by Turbo87 · Pull Request #158077 · rust-lang/rust

Turbo87 · 2026-06-18T10:39:12Z

bincode is flagged as unmaintained by RUSTSEC-2025-0141, and the advisory covers the entire crate with no patched version available. The only use in rustdoc-json-types was the binary serde roundtrip in the type tests.

postcard is a maintained serde-based binary serialization format that covers the same roundtrip testing need.

bincode is still pulled in transitively by the miri subtree (via ipc-channel), which needs to be addressed upstream.

bincode is flagged as unmaintained by RUSTSEC-2025-0141, and the advisory covers the entire crate with no patched version available. The only use in this crate was the binary serde roundtrip in the type tests. postcard (https://crates.io/crates/postcard) is a maintained serde-based binary serialization format that covers the same roundtrip testing need. bincode is still pulled in transitively by the miri subtree (via ipc-channel), which needs to be addressed upstream.

rustbot · 2026-06-18T10:39:15Z

rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing src/librustdoc/json/conversions.rs; otherwise, make sure you bump the FORMAT_VERSION constant.

cc @CraftSpider, @aDotInTheVoid, @Enselic, @obi1kenobi

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

rustbot · 2026-06-18T10:39:17Z

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @Mark-Simulacrum

Mark-Simulacrum · 2026-06-18T12:30:58Z

r? rustdoc

But generally speaking seems fine. I do wonder if there's a dependency-free way to test roundtripping? But seems OK.

Turbo87 · 2026-06-18T12:34:13Z

I do wonder if there's a dependency-free way to test roundtripping

we already seems to be roundtripping through serde_json and rkyv, so this is just a third way of doing it. whether any of that is actually necessary idk 😅

GuillaumeGomez · 2026-06-18T12:45:31Z

Feel free to send a PR if you have an idea on how to do it dependency-free. ;)

Thanks for the PR in any case!

@bors r+ rollup

rust-bors · 2026-06-18T12:45:34Z

📌 Commit fee82a3 has been approved by GuillaumeGomez

It is now in the queue for this repository.

…llaumeGomez rustdoc-json-types: Replace bincode dev-dependency with postcard bincode is flagged as unmaintained by [RUSTSEC-2025-0141](https://rustsec.org/advisories/RUSTSEC-2025-0141), and the advisory covers the entire crate with no patched version available. The only use in `rustdoc-json-types` was the binary serde roundtrip in the type tests. [postcard](https://crates.io/crates/postcard) is a maintained serde-based binary serialization format that covers the same roundtrip testing need. bincode is still pulled in transitively by the miri subtree (via `ipc-channel`), which needs to be [addressed upstream](rust-lang/miri#5115). ### Related - rust-lang/miri#5115

…uwer Rollup of 5 pull requests Successful merges: - #157935 (Make `proc_macro::ConversionErrorKind` non exhaustive) - #158002 (Replace `unwrap` with `expect` in `get_module_children`) - #158071 (Update actions/checkout action to v6) - #158072 (Bump thin-vec to 0.2.18 to address RUSTSEC-2026-0103) - #158077 (rustdoc-json-types: Replace bincode dev-dependency with postcard)

…llaumeGomez rustdoc-json-types: Replace bincode dev-dependency with postcard bincode is flagged as unmaintained by [RUSTSEC-2025-0141](https://rustsec.org/advisories/RUSTSEC-2025-0141), and the advisory covers the entire crate with no patched version available. The only use in `rustdoc-json-types` was the binary serde roundtrip in the type tests. [postcard](https://crates.io/crates/postcard) is a maintained serde-based binary serialization format that covers the same roundtrip testing need. bincode is still pulled in transitively by the miri subtree (via `ipc-channel`), which needs to be [addressed upstream](rust-lang/miri#5115). ### Related - rust-lang/miri#5115

…uwer Rollup of 10 pull requests Successful merges: - #158026 (`RegionValues`: disable unnecessary range check) - #156795 (Handle generic reborrow in expression-use adjustment walking) - #157694 (Enhance documentation on wake call memory ordering) - #157935 (Make `proc_macro::ConversionErrorKind` non exhaustive) - #158002 (Replace `unwrap` with `expect` in `get_module_children`) - #158034 (Fix reborrow source expression visits) - #158072 (Bump thin-vec to 0.2.18 to address RUSTSEC-2026-0103) - #158074 (Document transient connection errors from TcpListener::accept) - #158077 (rustdoc-json-types: Replace bincode dev-dependency with postcard) - #158086 (renovate: Loosen dashboard approval and adopt recommended config)

aDotInTheVoid · 2026-06-18T17:29:25Z

whether any of that is actually necessary idk 😅

The JSON test was added because there was a bug where it wouldn’t roundtrip (because of #[serde(untagged)]. The postcard test was added because it used to only work on self describing formats (for serde reasons I can’t remember). The rkyv tests were added to check we got the rkyv derives correct (because they’re complicated and not serde)

We should defiantly keep all three.

Rollup of 12 pull requests Successful merges: - #156795 (Handle generic reborrow in expression-use adjustment walking) - #157694 (Enhance documentation on wake call memory ordering) - #157935 (Make `proc_macro::ConversionErrorKind` non exhaustive) - #158002 (Replace `unwrap` with `expect` in `get_module_children`) - #158009 (Reject `impl const Trait` since the right syntax is `const impl Trait` now) - #158034 (Fix reborrow source expression visits) - #158072 (Bump thin-vec to 0.2.18 to address RUSTSEC-2026-0103) - #158074 (Document transient connection errors from TcpListener::accept) - #158077 (rustdoc-json-types: Replace bincode dev-dependency with postcard) - #158086 (renovate: Loosen dashboard approval and adopt recommended config) - #158088 (codegen_ssa: no dbginfo for scalable vec local w/ `-O0`) - #158089 (Fix invalid "jump-to-def" doc link generation when an item has a `derive` proc-macro)

Rollup merge of #158077 - Turbo87:bincode-replacement, r=GuillaumeGomez rustdoc-json-types: Replace bincode dev-dependency with postcard bincode is flagged as unmaintained by [RUSTSEC-2025-0141](https://rustsec.org/advisories/RUSTSEC-2025-0141), and the advisory covers the entire crate with no patched version available. The only use in `rustdoc-json-types` was the binary serde roundtrip in the type tests. [postcard](https://crates.io/crates/postcard) is a maintained serde-based binary serialization format that covers the same roundtrip testing need. bincode is still pulled in transitively by the miri subtree (via `ipc-channel`), which needs to be [addressed upstream](rust-lang/miri#5115). ### Related - rust-lang/miri#5115

Pulls in rust-lang/rust#158077

Rollup of 12 pull requests Successful merges: - rust-lang/rust#156795 (Handle generic reborrow in expression-use adjustment walking) - rust-lang/rust#157694 (Enhance documentation on wake call memory ordering) - rust-lang/rust#157935 (Make `proc_macro::ConversionErrorKind` non exhaustive) - rust-lang/rust#158002 (Replace `unwrap` with `expect` in `get_module_children`) - rust-lang/rust#158009 (Reject `impl const Trait` since the right syntax is `const impl Trait` now) - rust-lang/rust#158034 (Fix reborrow source expression visits) - rust-lang/rust#158072 (Bump thin-vec to 0.2.18 to address RUSTSEC-2026-0103) - rust-lang/rust#158074 (Document transient connection errors from TcpListener::accept) - rust-lang/rust#158077 (rustdoc-json-types: Replace bincode dev-dependency with postcard) - rust-lang/rust#158086 (renovate: Loosen dashboard approval and adopt recommended config) - rust-lang/rust#158088 (codegen_ssa: no dbginfo for scalable vec local w/ `-O0`) - rust-lang/rust#158089 (Fix invalid "jump-to-def" doc link generation when an item has a `derive` proc-macro)

rustbot added A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 18, 2026

rustbot assigned Mark-Simulacrum Jun 18, 2026

Turbo87 mentioned this pull request Jun 18, 2026

Update ipc-channel to 0.22 to drop bincode dependency rust-lang/miri#5115

Merged

rustbot assigned GuillaumeGomez and unassigned Mark-Simulacrum Jun 18, 2026

GuillaumeGomez approved these changes Jun 18, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2026

JonathanBrouwer mentioned this pull request Jun 18, 2026

Rollup of 5 pull requests #158079

Closed

JonathanBrouwer mentioned this pull request Jun 18, 2026

Rollup of 10 pull requests #158095

Closed

aDotInTheVoid approved these changes Jun 18, 2026

View reviewed changes

GuillaumeGomez mentioned this pull request Jun 18, 2026

Rollup of 12 pull requests #158098

Merged

rust-bors Bot merged commit 1813cd7 into rust-lang:main Jun 18, 2026
13 checks passed

rustbot added this to the 1.98.0 milestone Jun 18, 2026

aDotInTheVoid added a commit to aDotInTheVoid/rustdoc-types-contrib that referenced this pull request Jun 18, 2026

Replace bincode dev-dependency with postcard

0e1ba9b

Pulls in rust-lang/rust#158077

aDotInTheVoid mentioned this pull request Jun 18, 2026

Replace bincode dev-dependency with postcard rust-lang/rustdoc-types#63

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

rustdoc-json-types: Replace bincode dev-dependency with postcard#158077

rustdoc-json-types: Replace bincode dev-dependency with postcard#158077
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Turbo87:bincode-replacement

Turbo87 commented Jun 18, 2026 •

edited

Loading

Uh oh!

rustbot commented Jun 18, 2026

Uh oh!

rustbot commented Jun 18, 2026

Uh oh!

Mark-Simulacrum commented Jun 18, 2026

Uh oh!

Turbo87 commented Jun 18, 2026

Uh oh!

GuillaumeGomez commented Jun 18, 2026

Uh oh!

rust-bors Bot commented Jun 18, 2026

Uh oh!

aDotInTheVoid commented Jun 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

Turbo87 commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related

Uh oh!

rustbot commented Jun 18, 2026

Uh oh!

rustbot commented Jun 18, 2026

Uh oh!

Mark-Simulacrum commented Jun 18, 2026

Uh oh!

Turbo87 commented Jun 18, 2026

Uh oh!

GuillaumeGomez commented Jun 18, 2026

Uh oh!

rust-bors Bot commented Jun 18, 2026

Uh oh!

aDotInTheVoid commented Jun 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Turbo87 commented Jun 18, 2026 •

edited

Loading