Remove redundant check for #[loop_match] and #[const_continue]#158138
Merged
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_passes/src/check_attr.rs |
rustbot
added
A-attributes
Collaborator
|
|
JonathanBrouwer
approved these changes
Jun 19, 2026
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing |
obeis
changed the title
#[loop_match]#[loop_match] and #[const_continue]
JonathanBrouwer
requested changes
Jun 19, 2026
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
remove `check_loop_match` from `check_attr.rs` as it only verifies that the target is a loop, which is already enforced by `check_target` in `target_checking.rs` via `ALLOWED_TARGETS`, and its `LoopMatchAttr` diagnostic.
obeis
force-pushed
the
move-check-loop-match
branch
from
4ff8f9a to
569a2ff
Compare
remove `check_const_continue` from `check_attr.rs` as it only verifies that the target is a break, which is already enforced by `check_target` in `target_checking.rs` via `ALLOWED_TARGETS`, and it's's `ConstContinueAttr` diagnostic.
obeis
force-pushed
the
move-check-loop-match
branch
from
569a2ff to
620bf09
Compare
JonathanBrouwer
approved these changes
Jun 19, 2026
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 19, 2026
…uwer Rollup of 8 pull requests Successful merges: - #158129 (ensure the new solver bootstraps on CI) - #158134 (Rename `lint-rust-version` to `hint-msrv`) - #157926 (Implement `#[diagnostic::on_unknown]` for modules.) - #158075 (Point to the unstable segment of an import path instead of to the whole path) - #158084 (`-Znext-solver` Emit error instead of ICE when combining {int, float} var with alias) - #158128 (std: use correct low surrogate range in Windows standard I/O code) - #158132 (std: correctly report file size on UWP) - #158138 (Remove redundant check for `#[loop_match]` and `#[const_continue]`)
rust-timer
added a commit
that referenced
this pull request
Jun 19, 2026
Rollup merge of #158138 - obeis:move-check-loop-match, r=JonathanBrouwer Remove redundant check for `#[loop_match]` and `#[const_continue]` Updates #153101 remove `check_loop_match` and `check_const_continue` from `check_attr.rs` as they only verifies that the target, which is already enforced by `check_target` in `target_checking.rs` via `ALLOWED_TARGETS`. r? @JonathanBrouwer
Contributor
|
@rust-timer build cf6f8a0 |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
Finished benchmarking commit (cf6f8a0): comparison URL. Overall result: no relevant changes - no action neededBenchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up. @rustbot label: -S-waiting-on-perf -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary 2.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -5.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 481.965s -> 482.858s (0.19%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates #153101
remove
check_loop_matchandcheck_const_continuefromcheck_attr.rsas they only verifies that the target, which is already enforced bycheck_targetintarget_checking.rsviaALLOWED_TARGETS.r? @JonathanBrouwer