Add new ambiguity error for tools#158146
Draft
nbdd0121 wants to merge 1 commit into
Draft
Conversation
This implements the ambiguity error and stop the tool attributes from being affected by `#[no_implicit_prelude]` per the RFC. To avoid widespread ambiguity errors, the attribute tools are only resolved if they are resolved as part of macro path. `registered_tool_decls` is adjusted to use plain symbol instead of `IdentKey`; previously `ModuleGlobs` will adjust the ctxt to `ExpnId::root` so was comparing ignoring the ctxt anyway.
rustbot
added
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #66079
This implements the resolution changes of RFC 3808.
A new ambiguity error is added, and the tool attributes is no longer being affected by
#[no_implicit_prelude]per the RFC. This is a breaking change.To avoid widespread ambiguity errors, the attribute tools are only resolved if they are resolved as part of macro path (this could be further split to just attribute macros, but at which point we are kind of adding a new type of namespace?
Mark as draft until the implementation detail is agreed and a crater run is conducted.
r? @petrochenkov