Skip to content

Use the direct From in Clone for OnceLock<T>#158157

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
cuviper:once_lock-clone
Jun 20, 2026
Merged

Use the direct From in Clone for OnceLock<T>#158157
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
cuviper:once_lock-clone

Conversation

@cuviper

@cuviper cuviper commented Jun 19, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

This is a followup to #158101 as again, the complexity of set is not necessary here, especially because we can now use that direct From.

r? tgross35

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 19, 2026
@rustbot

rustbot commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

tgross35 is currently at their maximum review capacity.
They may take a while to respond.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@cuviper
Use the direct From in Clone for OnceLock<T>
cced652 
Again, the complexity of `set` is not necessary here.
tgross35
tgross35 approved these changes Jun 19, 2026
View reviewed changes

@tgross35 tgross35 left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+ rollup

View changes since this review

@rust-bors

rust-bors Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

📌 Commit cced652 has been approved by tgross35

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2026
@jhpratt jhpratt mentioned this pull request Jun 20, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Jun 20, 2026
@bors
Auto merge of #158162 - jhpratt:rollup-sVgABWZ, r=jhpratt
f3bf235 
Rollup of 3 pull requests

Successful merges:

 - #157976 (Improve `NumBufferTrait` associated items)
 - #157382 (Suggest `type` next to visibility for const items)
 - #158157 (Use the direct `From` in `Clone for OnceLock<T>`)
rust-bors Bot pushed a commit that referenced this pull request Jun 20, 2026
@bors
Auto merge of #158162 - jhpratt:rollup-sVgABWZ, r=jhpratt
8c75e93 
Rollup of 3 pull requests

Successful merges:

 - #157976 (Improve `NumBufferTrait` associated items)
 - #157382 (Suggest `type` next to visibility for const items)
 - #158157 (Use the direct `From` in `Clone for OnceLock<T>`)
@rust-bors rust-bors Bot merged commit e8809e3 into rust-lang:main Jun 20, 2026
13 checks passed
rust-timer added a commit that referenced this pull request Jun 20, 2026
@rust-timer
Unrolled build for #158157
32f1031 
Rollup merge of #158157 - cuviper:once_lock-clone, r=tgross35

Use the direct `From` in `Clone for OnceLock<T>`

This is a followup to #158101 as again, the complexity of `set` is not necessary here, especially because we can now use that direct `From`.

r? tgross35
@rustbot rustbot added this to the 1.98.0 milestone Jun 20, 2026
@jhpratt

jhpratt commented Jun 20, 2026

Copy link
Copy Markdown
Member

@rust-timer build 32f1031

@rust-timer

rust-timer commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

Missing artifact for sha 32f103161b10f6e919ef9f380d69e9d358b4c2b8 (https://ci-artifacts.rust-lang.org/rustc-builds/32f103161b10f6e919ef9f380d69e9d358b4c2b8/rustc-nightly-x86_64-unknown-linux-gnu.tar.xz); not built yet, try again later.

@jhpratt

jhpratt commented Jun 20, 2026

Copy link
Copy Markdown
Member

Looks like building that had a spurious failure. Relying on process of elimination, as the other two PRs in rollup #158162 are currently queued.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@tgross35 tgross35

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.98.0

Development

Successfully merging this pull request may close these issues.

6 participants

@cuviper @rustbot @rust-log-analyzer @jhpratt @rust-timer @tgross35