parse attrs if a loop's parent hir node is a stmt#158170
Open
usamoi wants to merge 1 commit into
Open
Conversation
saethlin
reviewed
Jun 20, 2026
| @@ -26,5 +26,24 @@ pub fn unroll_hint() { | |||
| } | |||
| } | |||
|
|
|||
Member
There was a problem hiding this comment.
Suggested change
| // HIR for a `loop` statement is a bit different, make sure we still apply the metadata in that case. |
saethlin
reviewed
Jun 20, 2026
Comment on lines
-77
to
+79
| if let hir::Node::Block(_) = self.tcx.parent_hir_node(hir_expr.hir_id) { | ||
| if let hir::Node::Block(_) | hir::Node::Stmt(_) = | ||
| self.tcx.parent_hir_node(hir_expr.hir_id) | ||
| { |
Member
There was a problem hiding this comment.
@JonathanBrouwer Is this the right way to fix this? I really don't know enough about HIR to be confident that this is the right way to handle things or if this is hack on a hack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix this case:
cc #156874
r? saethlin