Skip to content

update asm_experimental_reg comments#158172

Open
folkertdev wants to merge 1 commit into
rust-lang:mainfrom
folkertdev:asm-experimental-reg-comments
Open

update asm_experimental_reg comments#158172
folkertdev wants to merge 1 commit into
rust-lang:mainfrom
folkertdev:asm-experimental-reg-comments

Conversation

@folkertdev

Copy link
Copy Markdown
Contributor

Trivial bit of cleanup.

For s390x the vector registers are now stable, so asm_experimental_reg is no longer needed. That they need the target feature is already part of the ERROR assertion.

In the unstable book the title was incorrect.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 20, 2026
@rustbot

rustbot commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

r? @camelid

rustbot has assigned @camelid.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 17 candidates

@rust-log-analyzer

This comment has been minimized.

For s390x the vector registers are now stable. That they need the target feature is already part of the ERROR assertion
@folkertdev folkertdev force-pushed the asm-experimental-reg-comments branch from e61ac0e to 6375069 Compare June 20, 2026 11:06
@rustbot

rustbot commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants