std: unconditionally use preadv/pwritev on AArch64 macOS#158179
Open
joboet wants to merge 1 commit into
Open
Conversation
Collaborator
|
r? @Darksonn rustbot has assigned @Darksonn. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
How did you check which versions of macOS support preadv/pwritev? Maybe we can document that into https://doc.rust-lang.org/nightly/rustc/platform-support/apple-darwin.html or some other location (seems like more generally useful information). Also -- do we know if the non-macOS platforms support these (watchos/tvos/etc)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stars happened to line up perfectly: macOS 11.0 was the first version to support ARM, and also the first version with
preadv/pwritev. Thus we don't need to use weak linkage if the target isaarch64-apple-darwin.