Avoid uploading package-version on forced-channel jobs#158187
Open
Mark-Simulacrum wants to merge 1 commit into
Open
Avoid uploading package-version on forced-channel jobs#158187Mark-Simulacrum wants to merge 1 commit into
Mark-Simulacrum wants to merge 1 commit into
Conversation
This caused Crater to fail when installing the toolchain for commit 057ed8b, because it assumed the toolchain files would have package-version 1.98.0 (instead of nightly). This adjusts the code to always upload based on the canonical channel instead of the override.
rustbot
added
A-CI
Member
Author
|
@bors try jobs=dist-x86_64-linux,x86_64-gnu-stable |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 20, 2026
Avoid uploading package-version on forced-channel jobs try-job: dist-x86_64-linux try-job: x86_64-gnu-stable
Contributor
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-author
Collaborator
|
r? @marcoieni rustbot has assigned @marcoieni. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This caused Crater to fail when installing the toolchain for commit 057ed8b, because it assumed the toolchain files would have package-version 1.98.0 (instead of nightly).
This adjusts the code to always upload based on the canonical channel instead of the override.
See also notes on Zulip - #t-infra > Crater maybe stuck? @ 💬